Page MenuHomePhabricator
Differential D15812

Move ::hashAssumeValid into ChainstateManager
ClosedPublic
Actions

Authored by PiRK on Mar 29 2024, 14:49.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC69db3b4f2a4c: Move ::hashAssumeValid into ChainstateManager
Summary

This changes the assumed valid block for the bitcoin-chainstate
executable. Previously it was BlockHash{}, now it is defaultAssumeValid.

This is a partial backport of core#25704 and core#26409
https://github.com/bitcoin/bitcoin/pull/25704/commits/fa29d0b57cdeb91c8798d5c90ba9cc18085e99fb
https://github.com/bitcoin/bitcoin/pull/26409/commits/fa29ef00adac6f0842acdd38344820a1ce0e3087

Depends on D15811

Test Plan

ninja all check-all

Run IBD

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mar 29 2024, 14:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 29 2024, 14:49
PiRK requested review of this revision.Mar 29 2024, 14:49
teamcity edited the summary of this revision. (Show Details)Mar 29 2024, 14:49
PiRK added a child revision: D15813: Move ::nMinimumChainWork into ChainstateManager.Mar 29 2024, 14:52
Harbormaster completed remote builds in B28167: Diff 46599.Mar 29 2024, 15:18
Fabien requested changes to this revision.Mar 29 2024, 15:42
Fabien added a subscriber: Fabien.

Please run IBD as part of the test plan

This revision now requires changes to proceed.Mar 29 2024, 15:42
Fabien added a comment.Mar 29 2024, 15:42

@bot build-ibd

teamcity awarded a token.Mar 29 2024, 15:43
PiRK edited the test plan for this revision. (Show Details)Mar 30 2024, 09:16
PiRK requested review of this revision.Mar 30 2024, 10:16
Fabien accepted this revision.Mar 30 2024, 15:27
This revision is now accepted and ready to land.Mar 30 2024, 15:27
Closed by commit rABC69db3b4f2a4c: Move ::hashAssumeValid into ChainstateManager (authored by MacroFake <falke.marco@gmail.com>, committed by PiRK). · Explain WhyMar 30 2024, 17:23
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC69db3b4f2a4c: Move ::hashAssumeValid into ChainstateManager.

Revision Contents
Changeset List

PathSize
src/
4 lines
kernel/
5 lines
node/
4 lines
4 lines
14 lines
24 lines

Diff 46641

View Options

src/init.cpp

Loading...
View Options

src/kernel/chainstatemanager_opts.h

Loading...
View Options

src/node/chainstate.cpp

Loading...
View Options

src/node/chainstatemanager_args.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...