Page MenuHomePhabricator

Move ::hashAssumeValid into ChainstateManager
ClosedPublic

Authored by PiRK on Mar 29 2024, 14:49.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC69db3b4f2a4c: Move ::hashAssumeValid into ChainstateManager
Summary

This changes the assumed valid block for the bitcoin-chainstate
executable. Previously it was BlockHash{}, now it is defaultAssumeValid.

This is a partial backport of core#25704 and core#26409
https://github.com/bitcoin/bitcoin/pull/25704/commits/fa29d0b57cdeb91c8798d5c90ba9cc18085e99fb
https://github.com/bitcoin/bitcoin/pull/26409/commits/fa29ef00adac6f0842acdd38344820a1ce0e3087

Depends on D15811

Test Plan

ninja all check-all

Run IBD

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Mar 29 2024, 14:49
Fabien requested changes to this revision.Mar 29 2024, 15:42
Fabien added a subscriber: Fabien.

Please run IBD as part of the test plan

This revision now requires changes to proceed.Mar 29 2024, 15:42
PiRK requested review of this revision.Mar 30 2024, 10:16
This revision is now accepted and ready to land.Mar 30 2024, 15:27