As per title. Once the opcode activates, it needs to count as a sigops.
Depends on D1601
Details
Details
- Reviewers
schancel jasonbcox - Group Reviewers
Restricted Project - Commits
- rSTAGING5493be179c7c: Count OP_CHECKDATASIG and OP_CHECKDATASIGVERIFY as sigops when the proper flag…
rABC5493be179c7c: Count OP_CHECKDATASIG and OP_CHECKDATASIGVERIFY as sigops when the proper flag…
Added test cases.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- countcheckdatasig
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 3021 Build 4135: Bitcoin ABC Buildbot (legacy) Build 4134: arc lint + arc unit
Event Timeline
| src/test/sigopcount_tests.cpp | ||
|---|---|---|
| 31 ↗ | (On Diff #4451) | This entire patch will have to be cleaned up once the hardfork activates. Rather than add a datasigops param, you could have a flags param instead. Then, copy the GetSigOpCount test, but use the STANDARD_CHECKDATASIG_VERIFY_FLAGS instead of STANDARD_SCRIPT_VERIFY_FLAGS. The benefits of this are: more concise CheckScriptSigOps function, easier to read tests, and cleanup is as simple as deleting one of the tests (if necessary). |
Comment Actions
Rebase.
Having an API that do force one to specify the checkdatasig count is good. I don't see any situation where we clean that up, unless we change the way sigops are counted in the future and in that case, the whole test goes anyway.