Differential D16228

net_processing: move extra transactions to msgproc mutex
ClosedPublic
Actions

Authored by Fabien on May 28 2024, 13:34.

Tags

None

Subscribers

None

Tokens

"Haypence" token, awarded by teamcity.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCe88e4271c0d9: net_processing: move extra transactions to msgproc mutex

Summary

Previously vExtraTxnForCompact and vExtraTxnForCompactIt were protected
by g_cs_orphans; protect them by g_msgproc_mutex instead, as they
are only used during message processing.

Partial backport of core#26295:
https://github.com/bitcoin/bitcoin/pull/26295/commits/89e2e0da0bcd0b0757d7b42907e2d2214da9f68b

Depends on D16226.

Test Plan

With Clang and Debug:

ninja all check

./contrib/teamcity/build-configurations.py build-tsan

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR26295_2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29141
Build 57818: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 57817: arc lint + arc unit

Event Timeline

Fabien created this revision.May 28 2024, 13:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2024, 13:34

Fabien requested review of this revision.May 28 2024, 13:34

teamcity edited the summary of this revision. (Show Details)May 28 2024, 13:34

@bot build-tsan

teamcity awarded a token.May 28 2024, 13:36

Fabien added a child revision: D16229: net_processing: Pass a Peer& to ProcessOrphanTx.May 28 2024, 13:39

Harbormaster completed remote builds in B29141: Diff 47983.May 28 2024, 14:11

PiRK accepted this revision.May 28 2024, 15:40

This revision is now accepted and ready to land.May 28 2024, 15:40

Closed by commit rABCe88e4271c0d9: net_processing: move extra transactions to msgproc mutex (authored by Anthony Towns <aj@erisian.com.au>, committed by Fabien). · Explain WhyMay 29 2024, 07:46

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe88e4271c0d9: net_processing: move extra transactions to msgproc mutex.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

12 lines

2 lines

Diff 47983

src/net_processing.cpp

Loading...

src/txorphanage.h

Loading...