Paths

Table of Contentst

Differential D16268

[avalanche] pass the processor to Chainstate::ProcessNewBlock
ClosedPublic
Actions

Authored by PiRK on Jun 4 2024, 10:13.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCd8dfe18db234: [avalanche] pass the processor to Chainstate::ProcessNewBlock

Summary

Another step in removing access to the g_avalanche global in Chainstate code.

This adds some g_avalanche callsites in RPC commands, but they will be removed in a later diff when the node context owns avalanche.
Depends on D16267

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29201
Build 57938: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 57937: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 4 2024, 10:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2024, 10:13

PiRK requested review of this revision.Jun 4 2024, 10:13

PiRK added a child revision: D16269: [avalanche] pass the processor to Chainstate::PreciousBlock.

Harbormaster completed remote builds in B29201: Diff 48081.Jun 4 2024, 10:57

Fabien requested changes to this revision.Jun 4 2024, 11:54

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/rpc/mining.cpp
443	You should be able to mine blocks with avalanche disabled
1207	dito

This revision now requires changes to proceed.Jun 4 2024, 11:54

don't use EnsureAvalanche in the RPC calls, make it possible to use the RPCs with the processor not initialized

Harbormaster completed remote builds in B29208: Diff 48089.Jun 4 2024, 15:00

Fabien accepted this revision.Jun 4 2024, 16:30

This revision is now accepted and ready to land.Jun 4 2024, 16:30

Closed by commit rABCd8dfe18db234: [avalanche] pass the processor to Chainstate::ProcessNewBlock (authored by PiRK). · Explain WhyJun 5 2024, 08:35

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCd8dfe18db234: [avalanche] pass the processor to Chainstate::ProcessNewBlock.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

2 lines

rpc/

23 lines

4 lines

6 lines

Diff 48081

src/net_processing.cpp

Loading...

src/rpc/mining.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...