Pass a reference rather than a pointer, so that this function only ever gets called if there is an avalanche processor initialized.
This concludes the removal of g_avalanche access in Chainstate functions.
Depends on D16313
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC46f5b0863250: [avalanche] pass the processor to Chainstate::AvalancheFinalizeBlock
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 29203 Build 57942: Build Diff lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang Build 57941: arc lint + arc unit
Event Timeline
| src/validation.cpp | ||
|---|---|---|
| 2916 | You need to update isAvalancheEnabled to include the nullptr check. This is actually never null but this will prevent introducing bugs as we go because of that assumption | |
| src/validation.cpp | ||
|---|---|---|
| 2916 | OK. But in this place nothing is being done with g_avalanche, so this particular callsite does not lead to potential bugs. | |
Comment Actions
rebase on D16313 (now we can rely on the processor pointer to determine if avalanche is enabled)
| src/validation.cpp | ||
|---|---|---|
| 3695 ↗ | (On Diff #48179) | This looks like a place where you want to use a reference. Calling this function makes no sense if avalanche is disabled, so you want to check at callsite and not call this at all if avalanche is disabled. |
| 3702 ↗ | (On Diff #48179) | If avalanche is null this log is useless |
Comment Actions
pass a reference. This happens in a scope in which we have the guarantee that avalanche is initialized.
Initialize a couple of processors in tests, where this function is called.