[avalanche] pass the processor to Chainstate::AvalancheFinalizeBlock
ClosedPublic
Actions

Authored by PiRK on Jun 4 2024, 10:15.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

Summary

Pass a reference rather than a pointer, so that this function only ever gets called if there is an avalanche processor initialized.

This concludes the removal of g_avalanche access in Chainstate functions.

Depends on D16313

Test Plan

ninja all check-all

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29261
Build 58058: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 58057: arc lint + arc unit

PiRK created this revision.Jun 4 2024, 10:15

PiRK requested review of this revision.Jun 4 2024, 10:15

Fabien requested changes to this revision.Jun 4 2024, 11:58

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/validation.cpp
2916 ↗	(On Diff #48083)	You need to update isAvalancheEnabled to include the nullptr check. This is actually never null but this will prevent introducing bugs as we go because of that assumption

This revision now requires changes to proceed.Jun 4 2024, 11:58

PiRK added inline comments.Jun 4 2024, 14:15

src/validation.cpp
2916 ↗	(On Diff #48083)	OK. But in this place nothing is being done with g_avalanche, so this particular callsite does not lead to potential bugs.

rebase on D16313 (now we can rely on the processor pointer to determine if avalanche is enabled)

Fabien requested changes to this revision.Jun 7 2024, 08:45

Fabien added inline comments.

src/validation.cpp
3695	This looks like a place where you want to use a reference. Calling this function makes no sense if avalanche is disabled, so you want to check at callsite and not call this at all if avalanche is disabled.
3702	If avalanche is null this log is useless