Seperated enum class BlockValidity from chain.h into its own .h file and updated other .h and .cpp dependencies.
AbandonedPublic
Actions

Authored by nakihito on Aug 6 2018, 23:43.

Details

Reviewers

jasonbcox
deadalnix
schancel

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

Created new blockvalidity.h file removing enum class BlockValidity from chain.h. Also updated other .h and .cpp files using BlockValidity.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

SeperatingBlockValidityClass

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3032
Build 4157: Bitcoin ABC Buildbot (legacy)
Build 4156: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 6 2018, 23:43

Owners added a reviewer: Restricted Owners Package.Aug 6 2018, 23:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 6 2018, 23:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3032: Diff 4521!Aug 6 2018, 23:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

I think this needs to be rebased. There's been a lot of changes to blockvalidity by @deadalnix that don't seem to be here, and there's some autoconf problem.

schancel requested changes to this revision.Aug 7 2018, 19:11

This revision now requires changes to proceed.Aug 7 2018, 19:11

nakihito abandoned this revision.Aug 14 2018, 21:17

Revision Contents
Changeset List

Path

Size

src/

blockvalidity.h

50 lines

chain.h

43 lines

net_processing.cpp

1 line

rpc/

mining.cpp

1 line

test/

blockindex_tests.cpp

1 line

blockstatus_tests.cpp

1 line

validation.cpp

1 line

Diff 4521

View Options

src/blockvalidity.h

View Options

src/chain.h

View Options

src/net_processing.cpp

View Options

src/rpc/mining.cpp

View Options

src/test/blockindex_tests.cpp

View Options

src/test/blockstatus_tests.cpp

View Options

Seperated enum class BlockValidity from chain.h into its own .h file and updated other .h and .cpp dependencies.AbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4521

src/blockvalidity.h

src/chain.h

src/net_processing.cpp

src/rpc/mining.cpp

src/test/blockindex_tests.cpp

src/test/blockstatus_tests.cpp

src/validation.cpp

Seperated enum class BlockValidity from chain.h into its own .h file and updated other .h and .cpp dependencies.
AbandonedPublic
Actions

Revision Contents
Changeset List