[Cashtab] New validation function for user input NFT list price
ClosedPublic
Actions

Authored by bytesofman on Jul 17 2024, 22:15.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC78adf71f51e6: [Cashtab] New validation function for user input NFT list price

Summary

Splitting this out from D16328 to simplify review

Add new (and, here, unimplemented) function to validate user input NFT list price. This function is designed to work with Cashtab input field, i.e. if there is an error, we want to return the error so the user can know what is wrong.

See D16328 for implementation context.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

nft-list-price-validation

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 29627
Build 58789: Build Diff	ecash-lib-tests · cashtab-tests
Build 58788: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jul 17 2024, 22:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 17 2024, 22:15

better function comments

Harbormaster completed remote builds in B29617: Diff 48710.Jul 17 2024, 22:19

Harbormaster completed remote builds in B29618: Diff 48711.

bytesofman published this revision for review.Jul 17 2024, 22:29

emack requested changes to this revision.Jul 18 2024, 09:19

emack added a subscriber: emack.

emack added inline comments.

cashtab/src/validation/fixtures/vectors.js
2139 ↗	(On Diff #48711)	assuming 1 CAD does not crash below XEC dust IRL :)
2177 ↗	(On Diff #48711)	also test for '111.'
2198–2209 ↗	(On Diff #48711)	`ListPriceInput` in D16328 is of type `number` so these two are redundant
cashtab/src/validation/index.js
975 ↗	(On Diff #48711)	&& `if last char of xecListPrice is decimal point`