Differential D16823

[avalanche] Activate heartbeat on November 15, 2024
ClosedPublic
Actions

Authored by Fabien on Sep 30 2024, 13:42.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC502de3d7a9a1: [avalanche] Activate heartbeat on November 15, 2024

Summary

As per title. We deactivate the feature by default in tests because it doesn't play nicely with regtest. The feature enable flag is now public and documented.

Release notes will be added later in the version bump diff.

Test Plan

ninja all check-extended check-upgrade-activated-extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

rtt_activation

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30436
Build 60392: Build Diff	build-diff · build-debug · build-without-wallet · lint-circular-dependencies · check-iguana · build-clang · build-clang-tidy
Build 60391: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 30 2024, 13:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2024, 13:42

Fabien requested review of this revision.Sep 30 2024, 13:42

Fabien changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Sep 30 2024, 13:43

Fabien changed the edit policy from "All Users" to "Restricted Project (Project)".

Harbormaster completed remote builds in B30436: Diff 49854.Sep 30 2024, 14:06

PiRK accepted this revision.Sep 30 2024, 19:22

This revision is now accepted and ready to land.Sep 30 2024, 19:22

How about also adding a release note for Heartbeat in this Diff?

In D16823#381769, @Mengerian wrote:

How about also adding a release note for Heartbeat in this Diff?

That's in the summary: Release notes will be added later in the version bump diff.

I have several things to add so it's easier to do it all at once.

Closed by commit rABC502de3d7a9a1: [avalanche] Activate heartbeat on November 15, 2024 (authored by Fabien). · Explain WhyOct 2 2024, 13:21

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC502de3d7a9a1: [avalanche] Activate heartbeat on November 15, 2024.

Fabien changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Oct 3 2024, 19:26

Revision Contents
Changeset List

Path

Size

src/

7 lines

policy/

block/

5 lines

10 lines

rpc/

7 lines

test/

10 lines

test/

functional/

abc_feature_persist_headers_time.py

14 lines

abc_feature_rtt_activation.py

153 lines

abc_mining_rtt.py

5 lines

abc_p2p_avalanche_policy_rtt.py

22 lines

test_framework/

1 line

lint/

1 line

Diff 49854

src/init.cpp

Loading...

src/policy/block/rtt.h

Loading...

src/policy/block/rtt.cpp

Loading...

src/rpc/mining.cpp

Loading...

src/test/rtt_tests.cpp

Loading...

test/functional/abc_feature_persist_headers_time.py

Loading...

test/functional/abc_feature_rtt_activation.py

Loading...

test/functional/abc_mining_rtt.py

Loading...

test/functional/abc_p2p_avalanche_policy_rtt.py

Loading...

test/functional/test_framework/util.py

Loading...

test/lint/check-doc.py

Loading...