Page MenuHomePhabricator

build: Windows SSP roundup
ClosedPublic

Authored by Fabien on Thu, Nov 28, 20:24.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCcde55df45cfd: build: Windows SSP roundup
Summary
I was expecting this to fail to compile somewhere, maybe in the CI, but that doesn't seem to be the case?
Seems workable given the SSP related changes in the newer mingw-w64 headers (which are in Guix):

    Implement some of the stack protector functions/variables so -lssp is now optional when _FORTIFY_SOURCE or -fstack-protector-strong is used.

However I think this would still be broken in some older environments, so we might have to wait for a compiler bump, or similar. The optional -lssp also seems to work when using older headers, which doesn't make sense.

Backport of core#28461.

Test Plan

Run the GUIX windows build

Event Timeline

Fabien requested review of this revision.Thu, Nov 28, 20:24
This revision is now accepted and ready to land.Fri, Nov 29, 07:50
This revision was automatically updated to reflect the committed changes.