Page MenuHomePhabricator
Differential D1769

Use std::unique_ptr (C++11) where possible
ClosedPublic
Actions

Authored by deadalnix on Sep 11 2018, 18:09.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGb58315392f6a: Use std::unique_ptr (C++11) where possible
rABCb58315392f6a: Use std::unique_ptr (C++11) where possible
Summary
  • Use unique_ptr for pfilter (CBloomFilter)
  • Use unique_ptr for sem{Addnode,Outbound} (CSemaphore)

This is part of Core PR11043

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
netuniqueptr
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3274
Build 4635: Bitcoin ABC Buildbot (legacy)
Build 4634: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 11 2018, 18:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 11 2018, 18:09
teamcity added a subscriber: teamcity.Sep 11 2018, 18:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 11 2018, 18:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3271: Diff 4881.Sep 11 2018, 18:48
deadalnix updated this revision to Diff 4887.Sep 12 2018, 00:05

rebase

teamcity added a comment.Sep 12 2018, 00:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 12 2018, 00:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3274: Diff 4887.Sep 12 2018, 00:43
schancel accepted this revision.Sep 15 2018, 15:05
This revision is now accepted and ready to land.Sep 15 2018, 15:05
Closed by commit rABCb58315392f6a: Use std::unique_ptr (C++11) where possible (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by deadalnix). · Explain WhySep 15 2018, 16:57
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in D2229: Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy.Dec 28 2018, 15:52
Fabien mentioned this in rABC6c2476a5c9ed: Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy.Dec 31 2018, 13:18
Fabien mentioned this in rSTAGING6c2476a5c9ed: Use unique_ptr for pwalletMain,httpRPCTimerInterface,dbw,dbenv,pdbCopy.Jan 20 2019, 23:54

Revision Contents
Changeset List

PathSize
src/
6 lines
20 lines
6 lines

Diff 4887

View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_processing.cpp

Loading...