Depends on D17650
Support redemptions of Firma for $1 of XEC
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Project
npm test
Do it live at the test site, https://cashtab-local-dev.netlify.app/#/token/0387947fd575db4fb19a3e322f635dec37fd192b5941625b66bc4b2c3008cbf0
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- firma-redemptions
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 32520 Build 64528: Build Diff cashtab-tests Build 64527: arc lint + arc unit
Event Timeline
Comment Actions
Since the button will only work based on the external api, it's better to not show the button if the api is unavailable for some reason.
I suggest you do this:
- Attempt to retrieve the price from that endpoint
- If not successful, don't show the button. Otherwise show the button with the actual price, like "Redeem FIRMA for 1234 XEC"
- Not sure if it's worth refreshing periodically (in the even the price changes quickly)
Another point: can the slider be adjusted so that it starts at the minimum quantity and not at zero ? So you cannot move the cursor to the invalid zone, better UX
Comment Actions
Consider a 100% 50% 25% button above the Redeem button similar to binance. Easier for tax calculations when people are just partially selling rounded percentages.
| cashtab/src/components/Etokens/Token/index.tsx | ||
|---|---|---|
| 2377 ↗ | (On Diff #52772) | For the "Actual price", perhaps update to x,xxx XEC / FIRMA, otherwise it reads as if you'll be receiving that approximate amount selling a fraction of a FIRMA.  |
Comment Actions
yes, will need to get this in a separate diff. this is a generalized thing we need to put on the slider.
| cashtab/src/components/Etokens/Token/index.tsx | ||
|---|---|---|
| 2377 ↗ | (On Diff #52772) | added a "you receive" line that shows total amount  |
Comment Actions
I no longer see the redeem button anymore even though I have a FIRMA balance and am on the FIRMA token landing page.
I no longer see the redeem button anymore even though I have a FIRMA balance and am on the FIRMA token landing page.
v3.14.0 on the netlify instance after multiple refreshes