Differential D18419

[avalanche] Rename isAvalancheFinalized to isAvalancheFinalizedPreConsensus
ClosedPublic
Actions

Authored by Fabien on Jul 28 2025, 08:15.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC06cacdc6628c: [avalanche] Rename isAvalancheFinalized to isAvalancheFinalizedPreConsensus

Summary

This method only checks for finalization via preconsensus, the actual name is confusing even if it belongs to the mempool.

There is no change in behavior.

Test Plan

ninja all check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 28 2025, 08:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 28 2025, 08:15

Fabien requested review of this revision.Jul 28 2025, 08:15

Harbormaster completed remote builds in B33983: Diff 55014.Jul 28 2025, 08:26

Fabien added a child revision: D18420: [avalanche][chronik] Bridge the isAvalancheFinalizedPreconsensus method and use it for the tx is_final status.Jul 28 2025, 10:24

PiRK accepted this revision.Jul 28 2025, 12:22

This revision is now accepted and ready to land.Jul 28 2025, 12:22

Closed by commit rABC06cacdc6628c: [avalanche] Rename isAvalancheFinalized to isAvalancheFinalizedPreConsensus (authored by Fabien). · Explain WhyJul 29 2025, 07:29

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC06cacdc6628c: [avalanche] Rename isAvalancheFinalized to isAvalancheFinalizedPreConsensus.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

3 lines

policy/

block/

preconsensus.cpp

3 lines

rpc/

avalanche.cpp

5 lines

test/

16 lines

11 lines

2 lines

8 lines

3 lines

Diff 55016

View Options

src/net_processing.cpp

View Options

src/policy/block/preconsensus.cpp

View Options

src/rpc/avalanche.cpp

View Options

src/test/mempool_tests.cpp

View Options

src/test/miner_tests.cpp

View Options

src/txmempool.h

View Options

src/txmempool.cpp

View Options

[avalanche] Rename isAvalancheFinalized to isAvalancheFinalizedPreConsensusClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 55016

src/net_processing.cpp

src/policy/block/preconsensus.cpp

src/rpc/avalanche.cpp

src/test/mempool_tests.cpp

src/test/miner_tests.cpp

src/txmempool.h

src/txmempool.cpp

src/validation.cpp

[avalanche] Rename isAvalancheFinalized to isAvalancheFinalizedPreConsensus
ClosedPublic
Actions

Revision Contents
Changeset List