Page MenuHomePhabricator
Differential D18735

test: refactor: dedup `CBlockHeader` serialization
ClosedPublic
Actions

Authored by PiRK on Sep 30 2025, 13:15.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf08090597547: test: refactor: dedup `CBlockHeader` serialization
Summary

Note that we can't call .serialize() directly in
the .calc_sha256() method, as this could wrongly lead
to the serialization of the derived class (CBlock) if
called from an instance there.

This is a partial backport of core#32868
https://github.com/bitcoin/bitcoin/pull/32868/commits/f3c791d2e39133f33b04ebf790c307b0f63bb578
Depends on D18733

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 30 2025, 13:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2025, 13:15
PiRK requested review of this revision.Sep 30 2025, 13:15
teamcity edited the summary of this revision. (Show Details)Sep 30 2025, 13:15
PiRK updated this revision to Diff 56004.Sep 30 2025, 13:16
PiRK edited the summary of this revision. (Show Details)
PiRK added a parent revision: D18733: [test] factor some common block generation code in functional tests.

refactor on dependency

PiRK added a child revision: D18736: test: avoid direct block header modification.Sep 30 2025, 13:18
Harbormaster completed remote builds in B34683: Diff 56003.Sep 30 2025, 13:33
Harbormaster completed remote builds in B34684: Diff 56004.Sep 30 2025, 13:38
Fabien accepted this revision.Sep 30 2025, 17:51
This revision is now accepted and ready to land.Sep 30 2025, 17:51
Closed by commit rABCf08090597547: test: refactor: dedup `CBlockHeader` serialization (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhyOct 1 2025, 08:50
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCf08090597547: test: refactor: dedup `CBlockHeader` serialization.

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
12 lines

Diff 56023

View Options

test/functional/test_framework/messages.py

Loading...