Page MenuHomePhabricator
Differential D18742

test: avoid unneeded block header hash -> integer conversions
ClosedPublic
Actions

Authored by PiRK on Sep 30 2025, 15:04.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC9f0a0f0ce920: test: avoid unneeded block header hash -> integer conversions
Summary

This concludes backport of core#32868
https://github.com/bitcoin/bitcoin/pull/32868/commits/5fa34951ead2eebcced919537f5e27526f61d909
Depends on D18741

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 30 2025, 15:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2025, 15:04
teamcity edited the summary of this revision. (Show Details)Sep 30 2025, 15:04
Harbormaster completed remote builds in B34692: Diff 56016.Sep 30 2025, 15:42
teamcity added a comment.Sep 30 2025, 15:42
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_cltv.py ======

------- Stdout: -------
2025-09-30T15:40:07.461000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20250930_153853_27403/feature_cltv_199
2025-09-30T15:40:07.820000Z TestFramework (INFO): Mining 1349 blocks
2025-09-30T15:40:09.457000Z TestFramework (INFO): Test that an invalid-according-to-CLTV transaction can still appear in a block
2025-09-30T15:40:09.509000Z TestFramework (INFO): Test that blocks must now be at least version 4
2025-09-30T15:40:09.560000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 152, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/feature_cltv.py", line 122, in run_test
    assert_equal(self.nodes[0].getbestblockhash(), block.hash_hex)
  File "/work/test/functional/test_framework/util.py", line 59, in assert_equal
    raise AssertionError(
AssertionError: not(45facd0ac193dd3d93b210b371f929e15e535cb3fd8cc51cf2dfe55277edd24e == 4e5d963b7ab89d4d289fa546e5baa9457d06399292c0c2498d714c4c1022fc7c)
2025-09-30T15:40:09.611000Z TestFramework (INFO): Stopping nodes
2025-09-30T15:40:09.762000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20250930_153853_27403/feature_cltv_199
2025-09-30T15:40:09.762000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20250930_153853_27403/feature_cltv_199/test_framework.log
2025-09-30T15:40:09.762000Z TestFramework (ERROR): 
2025-09-30T15:40:09.762000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20250930_153853_27403/feature_cltv_199' to consolidate all logs
2025-09-30T15:40:09.762000Z TestFramework (ERROR): 
2025-09-30T15:40:09.762000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2025-09-30T15:40:09.763000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2025-09-30T15:40:09.763000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_cltv.py

teamcity added a comment.Sep 30 2025, 15:43
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_cltv.py ======

------- Stdout: -------
2025-09-30T15:41:40.777000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20250930_153737_61872/feature_cltv_199
2025-09-30T15:41:41.642000Z TestFramework (INFO): Mining 1349 blocks
2025-09-30T15:41:58.019000Z TestFramework (INFO): Test that an invalid-according-to-CLTV transaction can still appear in a block
2025-09-30T15:41:58.072000Z TestFramework (INFO): Test that blocks must now be at least version 4
2025-09-30T15:41:58.123000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 152, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/feature_cltv.py", line 122, in run_test
    assert_equal(self.nodes[0].getbestblockhash(), block.hash_hex)
  File "/work/test/functional/test_framework/util.py", line 59, in assert_equal
    raise AssertionError(
AssertionError: not(7b81957c5d816b9988acc5d6b05db02c7f26031730954d62702c73836511da56 == 766598378471ae5cf1493c0d9b4ea6e73c61b15d7ccaca637d2c05d1fa244292)
2025-09-30T15:41:58.174000Z TestFramework (INFO): Stopping nodes
2025-09-30T15:41:58.326000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20250930_153737_61872/feature_cltv_199
2025-09-30T15:41:58.326000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20250930_153737_61872/feature_cltv_199/test_framework.log
2025-09-30T15:41:58.326000Z TestFramework (ERROR): 
2025-09-30T15:41:58.326000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20250930_153737_61872/feature_cltv_199' to consolidate all logs
2025-09-30T15:41:58.326000Z TestFramework (ERROR): 
2025-09-30T15:41:58.326000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2025-09-30T15:41:58.326000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2025-09-30T15:41:58.326000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_cltv.py

teamcity added a comment.Sep 30 2025, 15:44
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_cltv.py ======

------- Stdout: -------
2025-09-30T15:40:06.969000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20250930_153807_27384/feature_cltv_199
2025-09-30T15:40:07.329000Z TestFramework (INFO): Mining 1349 blocks
2025-09-30T15:40:09.163000Z TestFramework (INFO): Test that an invalid-according-to-CLTV transaction can still appear in a block
2025-09-30T15:40:09.215000Z TestFramework (INFO): Test that blocks must now be at least version 4
2025-09-30T15:40:09.267000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 152, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/feature_cltv.py", line 122, in run_test
    assert_equal(self.nodes[0].getbestblockhash(), block.hash_hex)
  File "/work/test/functional/test_framework/util.py", line 59, in assert_equal
    raise AssertionError(
AssertionError: not(7135ca8b6b7b8b6b02e496ccc7ac9c4b7a9d8b2b18aefc23e939ef45ddbdd6c4 == 09ce99f8e66641818c986cf6af71b8554ea2c9ff6893201cd3fd193d91e05ebb)
2025-09-30T15:40:09.318000Z TestFramework (INFO): Stopping nodes
2025-09-30T15:40:09.469000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20250930_153807_27384/feature_cltv_199
2025-09-30T15:40:09.469000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20250930_153807_27384/feature_cltv_199/test_framework.log
2025-09-30T15:40:09.469000Z TestFramework (ERROR): 
2025-09-30T15:40:09.469000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20250930_153807_27384/feature_cltv_199' to consolidate all logs
2025-09-30T15:40:09.469000Z TestFramework (ERROR): 
2025-09-30T15:40:09.469000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2025-09-30T15:40:09.469000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2025-09-30T15:40:09.470000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: feature_cltv.py ======

------- Stdout: -------
2025-09-30T15:41:58.349000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20250930_154022_21052/feature_cltv_199
2025-09-30T15:41:58.711000Z TestFramework (INFO): Mining 1349 blocks
2025-09-30T15:42:00.517000Z TestFramework (INFO): Test that an invalid-according-to-CLTV transaction can still appear in a block
2025-09-30T15:42:00.570000Z TestFramework (INFO): Test that blocks must now be at least version 4
2025-09-30T15:42:00.621000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 152, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/feature_cltv.py", line 122, in run_test
    assert_equal(self.nodes[0].getbestblockhash(), block.hash_hex)
  File "/work/test/functional/test_framework/util.py", line 59, in assert_equal
    raise AssertionError(
AssertionError: not(08440c1bbd7c16012bba911076770aabc26d4bfed09d20743d8246c044983256 == 61556e338fe4a311538db2ac9ac42e786768fa23c0c4de826a9464d467aa9cb7)
2025-09-30T15:42:00.672000Z TestFramework (INFO): Stopping nodes
2025-09-30T15:42:00.823000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20250930_154022_21052/feature_cltv_199
2025-09-30T15:42:00.823000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20250930_154022_21052/feature_cltv_199/test_framework.log
2025-09-30T15:42:00.823000Z TestFramework (ERROR): 
2025-09-30T15:42:00.823000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20250930_154022_21052/feature_cltv_199' to consolidate all logs
2025-09-30T15:42:00.823000Z TestFramework (ERROR): 
2025-09-30T15:42:00.823000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2025-09-30T15:42:00.823000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2025-09-30T15:42:00.823000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_cltv.py
Bitcoin ABC functional tests with the next upgrade activated: feature_cltv.py

PiRK updated this revision to Diff 56021.Sep 30 2025, 18:26

unbreak feature_cltv

PiRK added a comment.Sep 30 2025, 18:26

@bot build-master

teamcity awarded a token.Sep 30 2025, 18:26
PiRK published this revision for review.Sep 30 2025, 18:40
Harbormaster completed remote builds in B34695: Diff 56021.Sep 30 2025, 18:42
Fabien accepted this revision.Oct 1 2025, 08:21
This revision is now accepted and ready to land.Oct 1 2025, 08:21
Closed by commit rABC9f0a0f0ce920: test: avoid unneeded block header hash -> integer conversions (authored by PiRK). · Explain WhyOct 1 2025, 08:51
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC9f0a0f0ce920: test: avoid unneeded block header hash -> integer conversions.

Revision Contents
Changeset List

Diff 56029

View Options

test/functional/feature_dersig.py

Loading...
View Options

test/functional/interface_zmq.py

Loading...
View Options

test/functional/p2p_compactblocks.py

Loading...
View Options

test/functional/p2p_compactblocks_blocksonly.py

Loading...
View Options

test/functional/p2p_sendheaders.py

Loading...