Paths

Table of Contentst

Differential D18740

`.hash_int` for consistency
ClosedPublic
Actions

Authored by PiRK on Sep 30 2025, 15:01.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCb464fc84e602: test: rename CBlockHeader `.rehash()`/`.sha256` -> `.hash_int` for consistency

Summary

Note that we unfortunately can't use a scripted diff here, as the
sha256 symbol is also used for other instances (e.g. as function
in hashlib, or in the UTXO class in p2p_segwit.py).

This is a partial backport of core#32868
https://github.com/bitcoin/bitcoin/pull/32868/commits/23be0ec2f074516a1177cda620a20e4c3ef1b28d

Depends on D18739

Test Plan

ninja check-functional-extended
chronik-client-integration-tests
build-chronik-plugins

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 30 2025, 15:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2025, 15:01

teamcity edited the summary of this revision. (Show Details)Sep 30 2025, 15:01

@bot chronik-client-integration-tests build-chronik-plugins

teamcity awarded a token.Sep 30 2025, 15:01

PiRK added a child revision: D18741: test: rename CBlockHeader .hash -> .hash_hex for consistency.Sep 30 2025, 15:03

Harbormaster completed remote builds in B34690: Diff 56014.Sep 30 2025, 15:29

PiRK published this revision for review.Sep 30 2025, 18:16

Fabien accepted this revision.Oct 1 2025, 08:09

This revision is now accepted and ready to land.Oct 1 2025, 08:09

Closed by commit rABCb464fc84e602: test: rename CBlockHeader `.rehash()`/`.sha256` -> `.hash_int` for consistency (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>, committed by PiRK). · Explain WhyOct 1 2025, 08:50

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCb464fc84e602: test: rename CBlockHeader `.rehash()`/`.sha256` -> `.hash_int` for consistency.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-invalid-chains.py

4 lines

abc-minimaldata.py

8 lines

abc-schnorr.py

8 lines

abc-schnorrmultisig.py

8 lines

abc-segwit-recovery.py

2 lines

abc-sync-chain.py

2 lines

abc-transaction-ordering.py

10 lines

abc_p2p_avalanche_policy_minerfund.py

8 lines

abc_p2p_avalanche_policy_rtt.py

8 lines

abc_p2p_avalanche_policy_stakingrewards.py

8 lines

abc_p2p_compactblocks.py

10 lines

abc_p2p_fullblocktest.py

4 lines

abc_rpc_isfinal.py

2 lines

chronik_mempool_disconnectpool.py

2 lines

chronik_pause.py

4 lines

example_test.py

4 lines

feature_63_bit_ints.py

8 lines

feature_assumeutxo.py

2 lines

feature_assumevalid.py

12 lines

feature_bip68_sequence.py

2 lines

feature_block.py

20 lines

feature_cltv.py

4 lines

feature_csv_activation.py

2 lines

feature_dersig.py

2 lines

feature_maxuploadtarget.py

2 lines

feature_pruning.py

2 lines

feature_tx_version.py

8 lines

interface_zmq.py

2 lines

mining_basic.py

2 lines

p2p_compactblocks.py

73 lines

p2p_compactblocks_blocksonly.py

16 lines

p2p_fingerprint.py

2 lines

p2p_getdata.py

2 lines

p2p_headers_sync_with_minchainwork.py

2 lines

p2p_ibd_stalling.py

6 lines

p2p_invalid_block.py

6 lines

p2p_mutated_blocks.py

4 lines

p2p_sendheaders.py

36 lines

p2p_unrequested_blocks.py

22 lines

rpc_blockchain.py

2 lines

rpc_getchaintips.py

2 lines

test_framework/

10 lines

10 lines

16 lines

2 lines

Diff 56027

View Options

test/functional/abc-invalid-chains.py

View Options

test/functional/abc-minimaldata.py

View Options

test/functional/abc-schnorr.py

View Options

test/functional/abc-schnorrmultisig.py

View Options

test/functional/abc-segwit-recovery.py

View Options

test/functional/abc-sync-chain.py

View Options

test/functional/abc-transaction-ordering.py

View Options

test/functional/abc_p2p_avalanche_policy_minerfund.py

View Options

test/functional/abc_p2p_avalanche_policy_rtt.py

View Options

test/functional/abc_p2p_avalanche_policy_stakingrewards.py

View Options

test/functional/abc_p2p_compactblocks.py

View Options

test/functional/abc_p2p_fullblocktest.py

View Options

test/functional/abc_rpc_isfinal.py

View Options

test/functional/chronik_mempool_disconnectpool.py

View Options

test/functional/chronik_pause.py

View Options

test/functional/example_test.py

View Options

test/functional/feature_63_bit_ints.py

View Options

test/functional/feature_assumeutxo.py

View Options

test/functional/feature_assumevalid.py

View Options

test/functional/feature_bip68_sequence.py

View Options

test/functional/feature_block.py

View Options

test/functional/feature_cltv.py

View Options

test/functional/feature_csv_activation.py

View Options

test/functional/feature_dersig.py

View Options

test/functional/feature_maxuploadtarget.py

View Options

test/functional/feature_pruning.py

View Options

test/functional/feature_tx_version.py

View Options

test/functional/interface_zmq.py

View Options

test/functional/mining_basic.py

View Options

test/functional/p2p_compactblocks.py

View Options

test/functional/p2p_compactblocks_blocksonly.py

View Options

test/functional/p2p_fingerprint.py

View Options

test/functional/p2p_getdata.py

View Options

test/functional/p2p_headers_sync_with_minchainwork.py

View Options

test/functional/p2p_ibd_stalling.py

View Options

test/functional/p2p_invalid_block.py

View Options

test/functional/p2p_mutated_blocks.py

View Options

test/functional/p2p_sendheaders.py

View Options

test/functional/p2p_unrequested_blocks.py

View Options

test/functional/rpc_blockchain.py

View Options

test/functional/rpc_getchaintips.py

View Options

test/functional/test_framework/blocktools.py

View Options

test/functional/test_framework/messages.py

View Options

test/functional/test_framework/p2p.py

View Options

test/functional/wallet_pruning.py

test: rename CBlockHeader `.rehash()`/`.sha256` -> `.hash_int` for consistencyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 56027

test/functional/abc-invalid-chains.py

test/functional/abc-minimaldata.py

test/functional/abc-schnorr.py

test/functional/abc-schnorrmultisig.py

test/functional/abc-segwit-recovery.py

test/functional/abc-sync-chain.py

test/functional/abc-transaction-ordering.py

test/functional/abc_p2p_avalanche_policy_minerfund.py

test/functional/abc_p2p_avalanche_policy_rtt.py

test/functional/abc_p2p_avalanche_policy_stakingrewards.py

test/functional/abc_p2p_compactblocks.py

test/functional/abc_p2p_fullblocktest.py

test/functional/abc_rpc_isfinal.py

test/functional/chronik_mempool_disconnectpool.py

test/functional/chronik_pause.py

test/functional/example_test.py

test/functional/feature_63_bit_ints.py

test/functional/feature_assumeutxo.py

test/functional/feature_assumevalid.py

test/functional/feature_bip68_sequence.py

test/functional/feature_block.py

test/functional/feature_cltv.py

test/functional/feature_csv_activation.py

test/functional/feature_dersig.py

test/functional/feature_maxuploadtarget.py

test/functional/feature_pruning.py

test/functional/feature_tx_version.py

test/functional/interface_zmq.py

test/functional/mining_basic.py

test/functional/p2p_compactblocks.py

test/functional/p2p_compactblocks_blocksonly.py

test/functional/p2p_fingerprint.py

test/functional/p2p_getdata.py

test/functional/p2p_headers_sync_with_minchainwork.py

test/functional/p2p_ibd_stalling.py

test/functional/p2p_invalid_block.py

test/functional/p2p_mutated_blocks.py

test/functional/p2p_sendheaders.py

test/functional/p2p_unrequested_blocks.py

test/functional/rpc_blockchain.py

test/functional/rpc_getchaintips.py

test/functional/test_framework/blocktools.py

test/functional/test_framework/messages.py

test/functional/test_framework/p2p.py

test/functional/wallet_pruning.py

test: rename CBlockHeader `.rehash()`/`.sha256` -> `.hash_int` for consistency
ClosedPublic
Actions

Revision Contents
Changeset List