Move CloseSocket out of SetSocketNonBlocking and pass SOCKET by const reference in SetSocket* functions
ClosedPublic
Actions

Authored by deadalnix on Oct 4 2018, 10:42.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING235da3f8f63f: Move CloseSocket out of SetSocketNonBlocking and pass SOCKET by const reference…
rABC235da3f8f63f: Move CloseSocket out of SetSocketNonBlocking and pass SOCKET by const reference…

Summary

This is a backport of core PR10865

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

moveclose

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3507
Build 5090: Bitcoin ABC Buildbot (legacy)
Build 5089: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 4 2018, 10:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 4 2018, 10:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3507: Diff 5266.Oct 4 2018, 11:00

jasonbcox accepted this revision.Oct 4 2018, 19:27

This revision is now accepted and ready to land.Oct 4 2018, 19:27

Closed by commit rABC235da3f8f63f: Move CloseSocket out of SetSocketNonBlocking and pass SOCKET by const reference… (authored by Dag Robole <dag.robole@gmail.com>, committed by deadalnix). · Explain WhyOct 4 2018, 21:03

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

2 lines

1 line

4 lines

12 lines

Diff 5266

View Options

src/compat.h

View Options

src/net.cpp

View Options

src/netbase.h

View Options

Move CloseSocket out of SetSocketNonBlocking and pass SOCKET by const reference in SetSocket* functionsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5266

src/compat.h

src/net.cpp

src/netbase.h

src/netbase.cpp

Move CloseSocket out of SetSocketNonBlocking and pass SOCKET by const reference in SetSocket* functions
ClosedPublic
Actions

Revision Contents
Changeset List