Page MenuHomePhabricator

Format chain.h and chain.cpp
ClosedPublic

Authored by deadalnix on Jun 13 2017, 16:23.

Details

Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

awemany requested changes to this revision.Jun 13 2017, 19:56

See code comment.

src/chain.h
19 ↗(On Diff #433)

That's the wrong doxygen comment, should be /// or //! here. Applies to the members below as well.

This revision now requires changes to proceed.Jun 13 2017, 19:56
src/chain.h
19 ↗(On Diff #433)

It is what is in the original diff.

deadalnix edited edge metadata.
src/chain.h
19 ↗(On Diff #433)

You mean you do the formatting first and then another clean-up patch on top?

My point was that that //!< is reserved for putting documentation after members, as per

https://www.stack.nl/~dimitri/doxygen/manual/docblocks.html

clang-format apparently doesn't know about this. So the diff as such would be a regression.

src/chain.h
19 ↗(On Diff #433)

ahhhhhhhhhhhh !

Well doxygen is broken already and we disabled it, but that's good to know. I'll attach this comment to the doc task and I think we should proceed here. We'll fix the doxygen thing once the HF fire is behind us.

This revision is now accepted and ready to land.Jun 13 2017, 22:54
This revision was automatically updated to reflect the committed changes.