As per title.
Details
Details
- Reviewers
freetrader sickpig kyuupichan - Group Reviewers
Restricted Project - Commits
- rSTAGING15a26fcee735: Format chain.h and chain.cpp
rABC15a26fcee735: Format chain.h and chain.cpp
make check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- chainfmt
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 268 Build 268: arc lint + arc unit
Event Timeline
Comment Actions
See code comment.
| src/chain.h | ||
|---|---|---|
| 19 ↗ | (On Diff #433) | That's the wrong doxygen comment, should be /// or //! here. Applies to the members below as well. |
| src/chain.h | ||
|---|---|---|
| 19 ↗ | (On Diff #433) | It is what is in the original diff. |
| src/chain.h | ||
|---|---|---|
| 19 ↗ | (On Diff #433) | You mean you do the formatting first and then another clean-up patch on top? My point was that that //!< is reserved for putting documentation after members, as per https://www.stack.nl/~dimitri/doxygen/manual/docblocks.html clang-format apparently doesn't know about this. So the diff as such would be a regression. |
| src/chain.h | ||
|---|---|---|
| 19 ↗ | (On Diff #433) | ahhhhhhhhhhhh ! Well doxygen is broken already and we disabled it, but that's good to know. I'll attach this comment to the doc task and I think we should proceed here. We'll fix the doxygen thing once the HF fire is behind us. |