Test LoadExternalBlockFile explictly for blocks larger than 2*MAX_TX_SIZE
ClosedPublic
Actions

Authored by awemany on Jun 13 2017, 18:22.

Details

Reviewers

deadalnix
freetrader
sickpig
kyuupichan

Group Reviewers

Restricted Project

Commits

rSTAGING39fe309bab18: Test LoadExternalBlockFile explictly for blocks larger than 2*MAX_TX_SIZE
rABC39fe309bab18: Test LoadExternalBlockFile explictly for blocks larger than 2*MAX_TX_SIZE

Summary

This checks that the buffering logic in CBufferedFile/LoadExternalBlockFile
works as intended and doesn't fail for blacks larger than the buffer size.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

awemany created this revision.Jun 13 2017, 18:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2017, 18:22

Harbormaster completed remote builds in B256: Diff 434.Jun 13 2017, 18:22

deadalnix requested changes to this revision.Jun 13 2017, 18:31

deadalnix added inline comments.

src/test/validation_tests.cpp
39 ↗	(On Diff #434)	Remove.
47 ↗	(On Diff #434)	size_t written = fwrite(chainparams.MessageStart(), CMessageHeader::MESSAGE_START_SIZE, 1, fp) BOOST_CHECK_EQUAL(written, 1);
55 ↗	(On Diff #434)	Please BOOST_CHECK the size of the block is larger than what you expect to test.
67 ↗	(On Diff #434)	I'm not sure what this is testing. You need to be asserting something at the end.