Page MenuHomePhabricator
Differential D18903

[lint] bump black to >=25
ClosedPublic
Actions

Authored by PiRK on Fri, Nov 7, 14:52.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCffdf9bfd6e3c: [lint] bump black to >=25
Summary

This is the yearly bumping for the black linter. Note that v25.x still supports python 3.9
See D15374 for the previous bump.

But this time it is probably the last bump, as this is an intermediate step before replacing black with ruff. This helps making the ruff diff smaller by fixing some differences in advance.

Test Plan
arc liberate
arc lint --everything

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Fri, Nov 7, 14:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Nov 7, 14:52
PiRK requested review of this revision.Fri, Nov 7, 14:52
PiRK added inline comments.Fri, Nov 7, 14:53
chronik/bitcoinsuite-slp/src/empp/mod.rs
48 ↗(On Diff #56515)

unrelated, rustfmt did this

PiRK added a child revision: D18904: [lint] switch from Black to Ruff for python code formatting.Fri, Nov 7, 14:55
Fabien requested changes to this revision.Fri, Nov 7, 15:19
Fabien added a subscriber: Fabien.

You need to update the CONTRIBUTING.md document accordingly

This revision now requires changes to proceed.Fri, Nov 7, 15:19
Harbormaster completed remote builds in B35011: Diff 56515.Fri, Nov 7, 15:58
PiRK added a child revision: D18912: [lint] add a blank line after module level docstring in python files.Mon, Nov 10, 07:54
PiRK updated this revision to Diff 56536.Mon, Nov 10, 08:11

update Contributing.md and install dependencies script

Harbormaster completed remote builds in B35028: Diff 56536.Mon, Nov 10, 08:36
teamcity added a comment.Mon, Nov 10, 08:36
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

Build 'Bitcoin ABC Diffs / Diff Testing' #103238, branch 'refs/tags/phabricator/diff/56536'
Triggered 2025-11-10 08:11:49 by 'Phabricator Staging (phabricator-staging)'
Started 2025-11-10 08:36:34 on agent 'buildagent9'
Finished 2025-11-10 08:36:34 with status FAILURE 'Unable to collect changes'
VCS revisions: 'BitcoinABC_BitcoinAbcStaging' (Git, instance id 22): 'N/A' (checkout rules: '+:. => ./bitcoin-abc')
TeamCity URL https://build.bitcoinabc.org/buildConfiguration/BitcoinABC_BitcoinAbcStaging/1011526 
TeamCity server version is 2025.03.1 (build 186125), server timezone: GMT (UTC)

[08:11:49]E: bt15 (24m:45s)
[08:11:49]i: TeamCity server version is 2025.03.1 (build 186125)
[08:11:49] : Finalize build settings
[08:11:49] : Collecting changes in 2 VCS roots
[08:11:49] :	 [Collecting changes in 2 VCS roots] VCS Root details
[08:11:49] :		 [VCS Root details] "Bitcoin ABC Staging" {instance id=22, parent internal id=3, parent id=BitcoinABC_BitcoinAbcStaging, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging.git#refs/heads/master"}
[08:11:49] :		 [VCS Root details] "abc-infrastructure" {instance id=24, parent internal id=7, parent id=AutomatedDeployments_BitcoinAbcDeveloperTools_AbcInfrastructure, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/infrastructure.git#refs/heads/master"}
[08:11:49]i: Loading current repository state for VCS root 'Bitcoin ABC Staging' (running for 24m:44s)
[08:11:49]i:	 [Loading current repository state for VCS root 'Bitcoin ABC Staging'] VCS root 'Bitcoin ABC Staging': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper14297576676367007276.sh ls-remote origin
[08:11:49]i:	 [Loading current repository state for VCS root 'Bitcoin ABC Staging'] VCS root 'Bitcoin ABC Staging': Warning: Permanently added '[reviews.bitcoinabc.org]:2221' (ED25519) to the list of known hosts.
[08:11:49]i:	 [Loading current repository state for VCS root 'Bitcoin ABC Staging'] Loading current repository state for VCS root 'abc-infrastructure' (running for 24m:44s)
[08:11:49]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper12924350980698048440.sh ls-remote origin
[08:11:49]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'abc-infrastructure': Warning: Permanently added '[reviews.bitcoinabc.org]:2221' (ED25519) to the list of known hosts.
[08:11:50]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': vcs@reviews.bitcoinabc.org: Permission denied (publickey,keyboard-interactive).
[08:11:50]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': fatal: Could not read from remote repository.
[08:11:50]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': 
[08:11:50]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': Please make sure you have the correct access rights
[08:11:50]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] VCS root 'Bitcoin ABC Staging': and the repository exists.
[08:11:50]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] Waiting for completion of current operations for the VCS root 'abc-infrastructure'
[08:11:51]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] Detecting changes in VCS root 'abc-infrastructure' (used in 'Bitcoin-ABC Infra Checkout', 'Extract Electrum ABC from ABC' and 5 other configurations)
[08:11:51]i:		 [Loading current repository state for VCS root 'abc-infrastructure'] Will collect changes for 'abc-infrastructure' starting from revision 602c7e2af027bb16cc6a4fc5a25601e8c853be5e
[08:11:51] : Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout
[08:11:51] :	 [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] Upper limit revision: 602c7e2af027bb16cc6a4fc5a25601e8c853be5e
[08:11:51]i:	 [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] MaxModId = 83296
[08:11:51] :	 [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] Computed revision: 602c7e2af027bb16cc6a4fc5a25601e8c853be5e
[08:36:34] : The build is removed from the queue to be prepared for the start
[08:36:34]E: Failed to collect changes, error: git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper14297576676367007276.sh ls-remote origin command failed.
exit code: 128
stderr: Warning: Permanently added '[reviews.bitcoinabc.org]:2221' (ED25519) to the list of known hosts.
vcs@reviews.bitcoinabc.org: Permission denied (publickey,keyboard-interactive).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists., VCS root: "Bitcoin ABC Staging" {instance id=22, parent internal id=3, parent id=BitcoinABC_BitcoinAbcStaging, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging.git#refs/heads/master"}
[08:36:34]E: Failed to collect changes, error: git -c credential.helper= -c credential.helper=/opt/teamcity/temp/credHelper14297576676367007276.sh ls-remote origin command failed.
exit code: 128
stderr: Warning: Permanently added '[reviews.bitcoinabc.org]:2221' (ED25519) to the list of known hosts.
vcs@reviews.bitcoinabc.org: Permission denied (publickey,keyboard-interactive).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists., VCS root: "Bitcoin ABC Staging" {instance id=22, parent internal id=3, parent id=BitcoinABC_BitcoinAbcStaging, description: "ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging.git#refs/heads/master"}
[08:36:34] : Build finished
Fabien accepted this revision.Mon, Nov 10, 09:10
This revision is now accepted and ready to land.Mon, Nov 10, 09:10
This revision was landed with ongoing or failed builds.Mon, Nov 10, 15:27
Closed by commit rABCffdf9bfd6e3c: [lint] bump black to >=25 (authored by PiRK). · Explain Why
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCffdf9bfd6e3c: [lint] bump black to >=25.

Revision Contents
Changeset List

Diff 56545

View Options

.arclint

Loading...
View Options

CONTRIBUTING.md

Loading...
View Options

arcanist/__phutil_library_map__.php

Loading...
View Options

chronik/bitcoinsuite-slp/src/empp/mod.rs

Loading...
View Options

contrib/tracing/log_raw_p2p_msgs.py

Loading...
View Options

contrib/tracing/p2p_monitor.py

Loading...
View Options

contrib/utils/install-dependencies-bookworm.sh

Loading...
View Options

electrum/electrumabc/avalanche/delegation.py

Loading...
View Options

electrum/electrumabc/avalanche/primitives.py

Loading...
View Options

electrum/electrumabc/json_util.py

Loading...
View Options

electrum/electrumabc/transaction.py

Loading...
View Options

test/functional/abc_rpc_getavalanchepeerinfo.py

Loading...
View Options

test/functional/feature_assumeutxo.py

Loading...
View Options

test/functional/feature_blocksdir.py

Loading...
View Options

test/functional/feature_dirsymlinks.py

Loading...
View Options

test/functional/interface_usdt_net.py

Loading...
View Options

test/functional/interface_usdt_utxocache.py

Loading...
View Options

test/functional/interface_usdt_validation.py

Loading...
View Options

test/functional/p2p_eviction.py

Loading...
View Options

test/functional/p2p_invalid_locator.py

Loading...
View Options

test/functional/p2p_ping.py

Loading...
View Options

test/functional/rpc_dumptxoutset.py

Loading...
View Options

test/functional/rpc_generateblock.py

Loading...
View Options

test/functional/rpc_getdescriptorinfo.py

Loading...
View Options

test/functional/rpc_psbt.py

Loading...
View Options

test/functional/test_framework/chronik/client.py

Loading...
View Options

test/functional/wallet_abandonconflict.py

Loading...
View Options

test/functional/wallet_watchonly.py

Loading...
View Options

test/fuzz/test_runner.py

Loading...
View Options

test/util/rpcauth-test.py

Loading...