Page MenuHomePhabricator

[lint] remove isort linter, enable isort in ruff
ClosedPublic

Authored by PiRK on Fri, Nov 7, 15:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC2ccfed5a9b22: [lint] remove isort linter, enable isort in ruff
Summary

For this we need the linter to be aware of the file path, even though we pass it via stdin, so it can detect the proper TOML configuration file to use.

Tested in various ways:

  • added unused import, checked that it is automatically removed
  • removed required import, checked that it causes a lint error
  • messed with the import ordering, checked that they are sorted after arc lint

Depends on D18905

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

most of the changes are caused by ruffs superior ability to detect which imports are standard lib vs first-party vs third-party.

PiRK published this revision for review.Fri, Nov 7, 16:03
This revision is now accepted and ready to land.Mon, Nov 10, 09:43