Page MenuHomePhabricator
Differential D18905

[lint] replace flake8 with ruff
ClosedPublic
Actions

Authored by PiRK on Fri, Nov 7, 15:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC34100ffa6547: [lint] replace flake8 with ruff
Summary

As per title

Depends on D18914

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Fri, Nov 7, 15:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Nov 7, 15:54
PiRK added a child revision: D18906: [lint] remove isort linter, enable isort in ruff.Fri, Nov 7, 15:54
PiRK added inline comments.Fri, Nov 7, 16:00
arcanist/linter/RuffCheckLinter.php
95 ↗(On Diff #56517)

some of the previous ignored rules don't even exist in Ruff. And C901 is a flake8 plugin we don't use which uses the same C prefix as rules from flake8-comprehensions.

97 ↗(On Diff #56517)

A is for flake8-builtins, C for flake8-comprehensions. E and F are the basic flake8 codes.
See https://docs.astral.sh/ruff/rules

contrib/testgen/base58.py
20 ↗(On Diff #56517)

i don't think we plan to support python 2 again in the future. This removes the need to fix an error.

PiRK published this revision for review.Fri, Nov 7, 16:01
Harbormaster completed remote builds in B35013: Diff 56517.Fri, Nov 7, 16:31
Fabien requested changes to this revision.Mon, Nov 10, 09:37
Fabien added a subscriber: Fabien.
Fabien added inline comments.
arcanist/linter/RuffCheckLinter.php
118 ↗(On Diff #56517)

It's a bit confusing that it's the same code as the ruff format linter. Can we suffix it to differentiate ?

contrib/testgen/base58.py
20–26 ↗(On Diff #56517)

Since we don't support python2, it's now native functions

This revision now requires changes to proceed.Mon, Nov 10, 09:37
PiRK updated this revision to Diff 56540.Mon, Nov 10, 11:10

suffix linter code

PiRK edited the summary of this revision. (Show Details)Mon, Nov 10, 11:12
PiRK added a parent revision: D18914: contrib: testgen: remove redundant base58 implementation.
PiRK added inline comments.Mon, Nov 10, 11:25
contrib/testgen/base58.py
20–26 ↗(On Diff #56517)

I just deleted that entire module in D18914. The fix was a bit too involved, as this codebase was hacking python 3 builtin functions to treat python 3 bytes as python 2 strings.

Harbormaster completed remote builds in B35031: Diff 56540.Mon, Nov 10, 11:40
Fabien accepted this revision.Mon, Nov 10, 12:51
This revision is now accepted and ready to land.Mon, Nov 10, 12:51
Closed by commit rABC34100ffa6547: [lint] replace flake8 with ruff (authored by PiRK). · Explain WhyMon, Nov 10, 15:27
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC34100ffa6547: [lint] replace flake8 with ruff.

Revision Contents
Changeset List

PathSize
10 lines
2 lines
arcanist/
linter/
127 lines
contrib/
linearize/
2 lines
utils/
2 lines
electrum/
electrumabc/
2 lines
2 lines
2 lines
2 lines
electrumabc_plugins/
keepkey/
2 lines
test/
functional/
4 lines

Diff 56549

View Options

.arclint

Loading...
View Options

CONTRIBUTING.md

Loading...
View Options

arcanist/__phutil_library_map__.php

Loading...
View Options

arcanist/linter/RuffCheckLinter.php

Loading...
View Options

contrib/linearize/linearize-data.py

Loading...
View Options

contrib/utils/install-dependencies-bookworm.sh

Loading...
View Options

electrum/electrumabc/json_db.py

Loading...
View Options

electrum/electrumabc/simple_config.py

Loading...
View Options

electrum/electrumabc/synchronizer.py

Loading...
View Options

electrum/electrumabc/transaction.py

Loading...
View Options

electrum/electrumabc_plugins/keepkey/keepkey.py

Loading...
View Options

test/functional/mempool_limit.py

Loading...