Page MenuHomePhabricator
Differential D18971

test: cover read-only blockstore
ClosedPublic
Actions

Authored by PiRK on Wed, Nov 19, 17:08.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa50ebbf5c376: test: cover read-only blockstore
Summary

Add a test to cover the behavior described in https://github.com/bitcoin/bitcoin/issues/2039, in preparation for fixing it.
I massaged the functional test: fewer levels of try-except wrapping, deduplication of the platform specific code (only the command name changes based on the OS)

This is a backport of core#28545, core#27850 and core#28660
Depends on D18969

Test Plan

ninja check check-functional

Try with the chattr unavailable on linux and check that the test is reported as skipped.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Nov 19, 17:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 19, 17:08
PiRK requested review of this revision.Wed, Nov 19, 17:08
teamcity edited the summary of this revision. (Show Details)Wed, Nov 19, 17:09
PiRK added inline comments.Wed, Nov 19, 17:10
test/functional/feature_reindex_readonly.py
55–58 ↗(On Diff #56687)

this is an improvement over the original test which succeeds even when it does not test anything. We will see that test is skipped instead of green.

PiRK updated this revision to Diff 56688.Wed, Nov 19, 17:12

don't log 3 warnings for a single message

PiRK edited the test plan for this revision. (Show Details)Wed, Nov 19, 17:13
Harbormaster completed remote builds in B35123: Diff 56687.Wed, Nov 19, 17:57
Harbormaster completed remote builds in B35124: Diff 56688.Wed, Nov 19, 18:04
PiRK edited the summary of this revision. (Show Details)Wed, Nov 19, 19:39
PiRK updated this revision to Diff 56689.Wed, Nov 19, 19:41

shebang --, file permissions

Harbormaster completed remote builds in B35125: Diff 56689.Wed, Nov 19, 19:57
Fabien accepted this revision.Thu, Nov 20, 09:03
This revision is now accepted and ready to land.Thu, Nov 20, 09:03
PiRK added a child revision: D18973: blockstorage: do not flush block to disk if it is already there.Thu, Nov 20, 10:53
Closed by commit rABCa50ebbf5c376: test: cover read-only blockstore (authored by Matthew Zipkin <pinheadmz@gmail.com>, committed by PiRK). · Explain WhyThu, Nov 20, 14:00
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCa50ebbf5c376: test: cover read-only blockstore.

Revision Contents
Changeset List

PathSize
contrib/
utils/
1 line
src/
test/
77 lines
test/
functional/
102 lines

Diff 56701

View Options

contrib/utils/install-dependencies-bookworm.sh

Loading...
View Options

src/test/blockmanager_tests.cpp

Loading...
View Options

test/functional/feature_reindex_readonly.py

Loading...