mining
ClosedPublic
Actions

Authored by deadalnix on Oct 9 2018, 13:39.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGa1073de668fa: Fix csBestBlock/cvBlockChange waiting in rpc/mining
rABCa1073de668fa: Fix csBestBlock/cvBlockChange waiting in rpc/mining

Summary

Modernize best block mutex/cv/hash variable naming

This is a backport of Core PR12743

Depends on D1902

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Oct 9 2018, 13:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 9 2018, 13:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3552: Diff 5339.Oct 9 2018, 13:56

lol "modernize"

This revision is now accepted and ready to land.Oct 9 2018, 20:56

Yes, I'm not sure the new names are actually better, but they do make backport easier.

Closed by commit rABCa1073de668fa: Fix csBestBlock/cvBlockChange waiting in rpc/mining (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyOct 9 2018, 22:15

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

init.cpp

2 lines

rpc/

mining.cpp

7 lines

validation.h

5 lines

validation.cpp

11 lines

Diff 5363

View Options

src/init.cpp

View Options

src/rpc/mining.cpp

View Options

src/validation.h

View Options

Fix csBestBlock/cvBlockChange waiting in rpc/miningClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5363

src/init.cpp

src/rpc/mining.cpp

src/validation.h

src/validation.cpp

Fix csBestBlock/cvBlockChange waiting in rpc/mining
ClosedPublic
Actions

Revision Contents
Changeset List