Page MenuHomePhabricator
Differential D1925

[qa] Add ATMP test for undersize transaction
ClosedPublic
Actions

Authored by jasonbcox on Oct 12 2018, 20:25.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING31c3a5723f99: [qa] Add ATMP test for undersize transaction
rABC31c3a5723f99: [qa] Add ATMP test for undersize transaction
Summary

Part 2 of many for incorporating changes from https://github.com/bitcoinxt/bitcoinxt/pull/487
Continues T418

Depends on D1930

Co-authored-by: Jason B. Cox <contact@jasonbcox.com>

Test Plan

test_runner.py abc-magnetic-anomaly-activation

Diff Detail

Repository
rABC Bitcoin ABC
Branch
undersize
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3607
Build 5289: Bitcoin ABC Buildbot (legacy)
Build 5288: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Oct 12 2018, 20:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2018, 20:25
jasonbcox edited the summary of this revision. (Show Details)Oct 12 2018, 20:26
teamcity added a subscriber: teamcity.Oct 12 2018, 20:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 12 2018, 20:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3587: Diff 5395.Oct 12 2018, 20:38
jasonbcox edited the summary of this revision. (Show Details)Oct 12 2018, 22:02
deadalnix requested changes to this revision.Oct 14 2018, 18:45
deadalnix added inline comments.
test/functional/abc-magnetic-anomaly-activation.py
270 ↗(On Diff #5395)

Check for this before accepting a block to make sure there is no off by one error.

This revision now requires changes to proceed.Oct 14 2018, 18:45
jasonbcox updated this revision to Diff 5430.Oct 16 2018, 18:05

Fixed potential off-by-one error

jasonbcox edited the summary of this revision. (Show Details)Oct 16 2018, 18:06
jasonbcox added a parent revision: D1930: [qa] Split out transaction creation from next_block in functional test.
teamcity added a comment.Oct 16 2018, 18:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 16 2018, 18:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3607: Diff 5430.Oct 16 2018, 18:15
deadalnix accepted this revision.Oct 16 2018, 21:26
This revision is now accepted and ready to land.Oct 16 2018, 21:26
Closed by commit rABC31c3a5723f99: [qa] Add ATMP test for undersize transaction (authored by dagurval, committed by jasonbcox). · Explain WhyOct 16 2018, 22:33
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
6 lines

Diff 5430

View Options

test/functional/abc-magnetic-anomaly-activation.py

Loading...