Page MenuHomePhabricator
Differential D1930

[qa] Split out transaction creation from next_block in functional test
ClosedPublic
Actions

Authored by jasonbcox on Oct 16 2018, 18:04.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING1652171d61b2: [qa] Split out transaction creation from next_block in functional test
rABC1652171d61b2: [qa] Split out transaction creation from next_block in functional test
Summary

This allows the easy creation of a tx to be used in this test without requiring next_block() to be called.
next_block() changes self.tip as a side effect, which is unexpected when only a tx is desired. This forces the test
writer to call tip(...) after generating invalid txs to bring the tip back to a good state. This is a bad code smell.

Test Plan

test_runner.py abc-magnetic-anomaly-activation

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ftest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3606
Build 5287: Bitcoin ABC Buildbot (legacy)
Build 5286: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Oct 16 2018, 18:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 16 2018, 18:04
teamcity added a subscriber: teamcity.Oct 16 2018, 18:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox added a child revision: D1925: [qa] Add ATMP test for undersize transaction.Oct 16 2018, 18:06
teamcity added a comment.Oct 16 2018, 18:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3606: Diff 5429.Oct 16 2018, 18:14
schancel accepted this revision.Oct 16 2018, 22:01
schancel retitled this revision from Split out transaction creation from next_block in functional test to [qa] Split out transaction creation from next_block in functional test.
This revision is now accepted and ready to land.Oct 16 2018, 22:02
Closed by commit rABC1652171d61b2: [qa] Split out transaction creation from next_block in functional test (authored by jasonbcox). · Explain WhyOct 16 2018, 22:32
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
121 lines

Diff 5429

View Options

test/functional/abc-magnetic-anomaly-activation.py

Loading...