Page MenuHomePhabricator

[qa] Split out transaction creation from next_block in functional test
ClosedPublic

Authored by jasonbcox on Oct 16 2018, 18:04.

Details

Summary

This allows the easy creation of a tx to be used in this test without requiring next_block() to be called.
next_block() changes self.tip as a side effect, which is unexpected when only a tx is desired. This forces the test
writer to call tip(...) after generating invalid txs to bring the tip back to a good state. This is a bad code smell.

Test Plan

test_runner.py abc-magnetic-anomaly-activation

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schancel retitled this revision from Split out transaction creation from next_block in functional test to [qa] Split out transaction creation from next_block in functional test.
This revision is now accepted and ready to land.Oct 16 2018, 22:02
This revision was automatically updated to reflect the committed changes.