Differential D1958

Make nBlockSequenceId atomic
ClosedPublic
Actions

Authored by deadalnix on Oct 21 2018, 22:27.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING408634e2a622: Make nBlockSequenceId atomic
rABC408634e2a622: Make nBlockSequenceId atomic

Summary

Also skip assignement when not required.

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

atomicsqid

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3655
Build 5385: Bitcoin ABC Buildbot (legacy)
Build 5384: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 21 2018, 22:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2018, 22:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox accepted this revision.Oct 21 2018, 22:35

This revision is now accepted and ready to land.Oct 21 2018, 22:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3655: Diff 5493.Oct 21 2018, 22:36

Closed by commit rABC408634e2a622: Make nBlockSequenceId atomic (authored by deadalnix). · Explain WhyOct 21 2018, 22:37

This revision was automatically updated to reflect the committed changes.

PiRK mentioned this in D17433: Move block-arrival information / preciousblock counters to ChainstateManager.Mon, Dec 30, 16:29

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

13 lines

Diff 5493

View Options

Make nBlockSequenceId atomicClosedPublicActions