Page MenuHomePhabricator
Differential D1992

Rename wallet functional test files to match bitcoin core
ClosedPublic
Actions

Authored by schancel on Oct 31 2018, 23:16.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING9e90803c6e02: Rename wallet functional test files to match bitcoin core
rABC9e90803c6e02: Rename wallet functional test files to match bitcoin core
Summary

Per title. Depends on D1986

Test Plan
./test/functional/test_runner.py wallet_*.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rename-wallet-tests (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3736
Build 5547: Bitcoin ABC Buildbot (legacy)
Build 5546: arc lint + arc unit

Event Timeline

schancel created this revision.Oct 31 2018, 23:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2018, 23:16
schancel edited the summary of this revision. (Show Details)Oct 31 2018, 23:16
schancel added a parent revision: D1986: Rename account to label where appropriate.
teamcity added a subscriber: teamcity.Oct 31 2018, 23:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 31 2018, 23:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3736: Diff 5604.Oct 31 2018, 23:43
deadalnix requested changes to this revision.Nov 1 2018, 01:29
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
test/functional/timing.json
34

Run the extended test suite to regenerate these results.

This revision now requires changes to proceed.Nov 1 2018, 01:29
schancel updated this revision to Diff 5610.Nov 1 2018, 02:32

Fix timings

teamcity added a comment.Nov 1 2018, 02:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel updated this revision to Diff 5611.Nov 1 2018, 02:34

Fix timings once more

schancel updated this revision to Diff 5612.Nov 1 2018, 02:36

...

teamcity added a comment.Nov 1 2018, 02:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 1 2018, 02:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 1 2018, 02:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3739: Diff 5610.Nov 1 2018, 02:44
teamcity added a comment.Nov 1 2018, 02:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3741: Diff 5612.Nov 1 2018, 02:46
teamcity added a comment.Nov 1 2018, 02:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3740: Diff 5611.Nov 1 2018, 02:46
Fabien requested changes to this revision.Nov 1 2018, 14:21
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/timing.json
351 ↗(On Diff #5612)

Should be zmq_test.py ?

This revision now requires changes to proceed.Nov 1 2018, 14:21
schancel marked an inline comment as done.Nov 2 2018, 00:41
schancel added inline comments.
test/functional/timing.json
351 ↗(On Diff #5612)

Yes, gfrr. I'm having to manually update this file because tests don't currently complete on my machine. I need to get to the bottom of that.

schancel updated this revision to Diff 5621.Nov 2 2018, 00:42

Fix timings.json again

teamcity added a comment.Nov 2 2018, 00:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 2 2018, 00:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3747: Diff 5621.Nov 2 2018, 00:54
Fabien accepted this revision.Nov 2 2018, 13:02
deadalnix accepted this revision.Nov 4 2018, 18:26
This revision is now accepted and ready to land.Nov 4 2018, 18:26
schancel removed a parent revision: D1937: Change the maxtxfee to be per kb..Nov 6 2018, 23:25
schancel updated this revision to Diff 6181.Nov 29 2018, 21:39

Rebase an update timings

teamcity added a comment.Nov 29 2018, 21:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 29 2018, 21:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4177: Diff 6181.Nov 29 2018, 21:50
Closed by commit rABC9e90803c6e02: Rename wallet functional test files to match bitcoin core (authored by schancel). · Explain WhyNov 29 2018, 21:50
This revision was automatically updated to reflect the committed changes.
deadalnix added inline comments.Nov 29 2018, 22:55
test/functional/timing.json
27 ↗(On Diff #6182)

?

91 ↗(On Diff #6182)

?

245 ↗(On Diff #6182)

??

Revision Contents
Changeset List

PathSize
test/
functional/
190 lines
wallet_accounts.py
wallet-accounts.py
209 lines
wallet_dump.py
wallet-dump.py
122 lines
wallet_encryption.py
wallet-encryption.py
68 lines
wallet_hd.py
wallet-hd.py
137 lines
167 lines

Diff 5604

View Options

test/functional/receivedby.py

Loading...
View Options

test/functional/timing.json

Loading...
View Options

test/functional/wallet-accounts.py

Loading...
View Options

test/functional/wallet-dump.py

Loading...
View Options

test/functional/wallet-encryption.py

Loading...
View Options

test/functional/wallet-hd.py

Loading...
View Options

test/functional/wallet_accounts.py

Loading...
View Options

test/functional/wallet_dump.py

Loading...
View Options

test/functional/wallet_encryption.py

Loading...
View Options

test/functional/wallet_hd.py

Loading...
View Options

test/functional/wallet_receivedby.py

Loading...