Page MenuHomePhabricator

Update release notes to include several missing items
ClosedPublic

Authored by schancel on Nov 1 2018, 02:39.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Nov 1 2018, 02:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 1 2018, 02:39
Fabien requested changes to this revision.Nov 1 2018, 14:01
Fabien added a subscriber: Fabien.
Fabien added inline comments.
doc/release-notes.md
15 ↗(On Diff #5613)

Should be moved to new "Backports from Bitcoin Core" section

This revision now requires changes to proceed.Nov 1 2018, 14:01
Fabien added inline comments.Nov 2 2018, 16:48
doc/release-notes.md
11 ↗(On Diff #5620)

The existence of this section is being discussed in D1986

jasonbcox added inline comments.
doc/release-notes.md
11 ↗(On Diff #5620)

From that discussion, it seems a little valuable to just list this as RPC backports from Core: and move the non-RPC comments up above. Thoughts?

Fabien added inline comments.Nov 2 2018, 18:09
doc/release-notes.md
11 ↗(On Diff #5620)

From my point of view, this release note is not consistent enough to spend much time sorting it with categories. Furthermore "RPC backports" has a narrow scope. We can later discuss a template if the release notes are expected to be significantly larger.

deadalnix requested changes to this revision.Nov 4 2018, 12:52
This revision now requires changes to proceed.Nov 4 2018, 12:52
schancel updated this revision to Diff 5653.Nov 5 2018, 22:45

Update per feedback

Fabien requested changes to this revision.Nov 5 2018, 23:01
This revision now requires changes to proceed.Nov 5 2018, 23:01
Fabien added inline comments.Nov 5 2018, 23:14
doc/release-notes.md
19 ↗(On Diff #5653)

Duplicated line

schancel updated this revision to Diff 5654.Nov 5 2018, 23:15

Remove duplicate

Fabien accepted this revision.Nov 5 2018, 23:16
This revision is now accepted and ready to land.Nov 5 2018, 23:17
This revision was automatically updated to reflect the committed changes.