Differential D1995

Fixed a bug where an invalidated or parked block would have child state applied to it even when its parent block is not invalidated or parked.
ClosedPublic
Actions

Authored by jasonbcox on Nov 1 2018, 17:07.

Tags

None

Subscribers

Details

Reviewers

deadalnix
schancel
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING638c2fbd9748: Fixed a bug where an invalidated or parked block would have child state applied…
rABC638c2fbd9748: Fixed a bug where an invalidated or parked block would have child state applied…

Summary

Discovered while debugging parked chain behavior. I noticed the BlockStatus had unexpected combinations of state. With a chain A->B->C (tip):

parkblock(blockB) produces: A (no state change) -> B (parked, parked-parent) -> C (parked-parent)
Expected is: A (no state change) -> B (parked) -> C (parked-parent)

invalidateblock(blockB) produces: A (no state change) -> B (invalid, invalid-parent) -> C (invalid-parent)
Expected is: A (no state change) -> B (invalid) -> C (invalid-parent)

Test Plan

test_runner.py abc-parkedchain

Diff Detail

Repository

rABC Bitcoin ABC

Branch

d1987-2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3743
Build 5561: Bitcoin ABC Buildbot (legacy)
Build 5560: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Nov 1 2018, 17:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 1 2018, 17:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3743: Diff 5616.Nov 1 2018, 17:16

jasonbcox added a child revision: D1977: Merge #11531: Check that new headers are not a descendant of an invalid block (more effeciently).Nov 1 2018, 18:48

This change is actually incorporated into this backport: D1977, so is unnecessary as long as that change gets in soon.

Then again, I don't think it's a good assumption to think D1977 will go through a quick review. This fix may be necessary in the short term.

jasonbcox edited the summary of this revision. (Show Details)Nov 1 2018, 20:39

Fabien accepted this revision.Nov 2 2018, 17:23

This revision is now accepted and ready to land.Nov 2 2018, 17:23

deadalnix accepted this revision.Nov 2 2018, 22:11

Closed by commit rABC638c2fbd9748: Fixed a bug where an invalidated or parked block would have child state applied… (authored by jasonbcox). · Explain WhyNov 2 2018, 22:12

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

10 lines

Diff 5616

src/validation.cpp

Loading...