Differential D1996

Added parked state to getchaintips RPC
ClosedPublic
Actions

Authored by jasonbcox on Nov 1 2018, 17:49.

Details

Reviewers

deadalnix
schancel
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING2b6aabf0557d: Added parked state to getchaintips RPC
rABC2b6aabf0557d: Added parked state to getchaintips RPC

Summary

Adding 'parked' state to getchaintips RPC so that it's not confusing when parked chains return 'valid-fork'.

Test Plan

test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

rpc-parked

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3744
Build 5563: Bitcoin ABC Buildbot (legacy)
Build 5562: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Nov 1 2018, 17:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 1 2018, 17:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3744: Diff 5617.Nov 1 2018, 17:59

Fabien accepted this revision as: Fabien.Nov 2 2018, 21:45

This revision is now accepted and ready to land.Nov 2 2018, 21:45

Closed by commit rABC2b6aabf0557d: Added parked state to getchaintips RPC (authored by jasonbcox). · Explain WhyNov 2 2018, 22:21

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

doc/

release-notes.md

1 line

src/

rpc/

blockchain.cpp

13 lines

test/

functional/

abc-parkedchain.py

16 lines

Diff 5617

View Options

doc/release-notes.md

View Options

src/rpc/blockchain.cpp

View Options

test/functional/abc-parkedchain.py

Added parked state to getchaintips RPCClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5617

doc/release-notes.md

src/rpc/blockchain.cpp

test/functional/abc-parkedchain.py

Added parked state to getchaintips RPC
ClosedPublic
Actions

Revision Contents
Changeset List