Remove globals.h use from net.cpp
ClosedPublic
Actions

Authored by deadalnix on Jun 15 2017, 12:10.

Details

Reviewers

freetrader
sickpig
kyuupichan
awemany

Group Reviewers

Restricted Project

Commits

rSTAGINGd2939c33b08c: Remove globals.h use from net.cpp
rABCd2939c33b08c: Remove globals.h use from net.cpp

Summary

The only place where it is used is to compute a buffer size, and it doesn't really need to be used there. ONE8MEGABYTE is good enough.

Test Plan

make check
../qa/pull-tester/rpc-tests.py maxuploadtarget.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

netglobals

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 298
Build 298: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 15 2017, 12:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2017, 12:10

Harbormaster completed remote builds in B298: Diff 494.Jun 15 2017, 12:10

deadalnix added a child revision: D207: Change default for excessive block size and generated block size.Jun 15 2017, 14:26

Code changes look ok for current test, and I can accept on that basis.

I will make myself a task to verify whether maxuploadtarget.py still passes if bigger blocks (i.e. the user's max upload target is respected even if blocks are >> 1MB).
Best would be to extend maxuploadtarget.py test accordingly to do a bigger-block check.

This revision is now accepted and ready to land.Jun 16 2017, 11:06

Closed by commit rABCd2939c33b08c: Remove globals.h use from net.cpp (authored by deadalnix, committed by deadalnix). · Explain WhyJun 16 2017, 11:08

This revision was automatically updated to reflect the committed changes.