Page MenuHomePhabricator

Fixed p2p-compactblocks failures
ClosedPublic

Authored by jasonbcox on Nov 17 2018, 18:18.

Details

Summary

CTOR changes tx ordering, so selecting hand-picked tx indices in a block is no longer possible. Fixes this + tx padding

Test Plan

test_runner.py p2p-compactblocks

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Nov 17 2018, 18:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 17 2018, 18:18
jasonbcox updated this revision to Diff 5855.Nov 17 2018, 18:20

Removed debug print statement

deadalnix added inline comments.Nov 17 2018, 18:57
test/functional/p2p-compactblocks.py
502 ↗(On Diff #5855)

Why do something so complex ? It only matter that you you prefix 4 out of 6.

deadalnix requested changes to this revision.Nov 17 2018, 18:57
This revision now requires changes to proceed.Nov 17 2018, 18:57
jasonbcox marked 2 inline comments as done.Nov 17 2018, 19:09
jasonbcox added inline comments.
test/functional/p2p-compactblocks.py
502 ↗(On Diff #5855)

The indices need to be determined to verify that the tx other than the one put in the mempool (see code block above) is the only remaining tx.

jasonbcox marked an inline comment as done.Nov 18 2018, 00:46
deadalnix accepted this revision.Nov 18 2018, 01:04
This revision is now accepted and ready to land.Nov 18 2018, 01:04
This revision was automatically updated to reflect the committed changes.