Page MenuHomePhabricator
Differential D2078

Fixed p2p-compactblocks failures
ClosedPublic
Actions

Authored by jasonbcox on Nov 17 2018, 18:18.

Details

Reviewers
deadalnix
schancel
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING388d3c1f12b2: Fixed p2p-compactblocks failures
rABC388d3c1f12b2: Fixed p2p-compactblocks failures
Summary

CTOR changes tx ordering, so selecting hand-picked tx indices in a block is no longer possible. Fixes this + tx padding

Test Plan

test_runner.py p2p-compactblocks

Diff Detail

Repository
rABC Bitcoin ABC
Branch
compactblocks
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3928
Build 5928: Bitcoin ABC Buildbot (legacy)
Build 5927: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Nov 17 2018, 18:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 17 2018, 18:18
jasonbcox updated this revision to Diff 5855.Nov 17 2018, 18:20

Removed debug print statement

deadalnix added inline comments.Nov 17 2018, 18:57
test/functional/p2p-compactblocks.py
502 ↗(On Diff #5855)

Why do something so complex ? It only matter that you you prefix 4 out of 6.

deadalnix requested changes to this revision.Nov 17 2018, 18:57
This revision now requires changes to proceed.Nov 17 2018, 18:57
jasonbcox marked 2 inline comments as done.Nov 17 2018, 19:09
jasonbcox added inline comments.
test/functional/p2p-compactblocks.py
502 ↗(On Diff #5855)

The indices need to be determined to verify that the tx other than the one put in the mempool (see code block above) is the only remaining tx.

teamcity added a subscriber: teamcity.Nov 17 2018, 20:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 17 2018, 20:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

teamcity added a comment.Nov 17 2018, 20:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3928: Diff 5854!Nov 17 2018, 20:14
teamcity added a comment.Nov 17 2018, 20:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3929: Diff 5855!Nov 17 2018, 20:18
jasonbcox marked an inline comment as done.Nov 18 2018, 00:46
deadalnix accepted this revision.Nov 18 2018, 01:04
This revision is now accepted and ready to land.Nov 18 2018, 01:04
Closed by commit rABC388d3c1f12b2: Fixed p2p-compactblocks failures (authored by jasonbcox). · Explain WhyNov 18 2018, 01:56
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
68 lines

Diff 5854

View Options

test/functional/p2p-compactblocks.py

Loading...