Now that we ensure that the 1MB limit is respected before the fork is activated, we can safely increase defaults up to the value we want for the UAHF.
The generated block size is increased to 2MB and the maximum block size to 8MB by default.
Details
Details
- Reviewers
freetrader sickpig awemany kyuupichan - Group Reviewers
Restricted Project - Commits
- rSTAGING00cb8ae2a238: Change default for excessive block size and generated block size
rABC00cb8ae2a238: Change default for excessive block size and generated block size
Updated tests to ensure the behavior is as expected.
Run the extended test suite to make sure they all pass.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- newdefaults
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 301 Build 301: arc lint + arc unit
Event Timeline
Comment Actions
Just revert the Python wildcard import please, rest is fine.
| qa/rpc-tests/abc-p2p-fullblocktest.py | ||
|---|---|---|
| 21 | No. Do not add wildcard imports to tests. This is bad Python practice just like blanket namespace imports are in C++ :-) If the list gets too long, put them in parentheses and spread them over multiple lines. | |
| qa/rpc-tests/abc-rpc.py | ||
| 50 | Why the specific EB change down from 8MB to 2MB without retaining higher-EB checks? I would advise even setting to a high size like 16MB or 32MB in addition to the 2MB check. | |
| qa/rpc-tests/abc-rpc.py | ||
|---|---|---|
| 50 | Because 8MB is now the default, so it is testing nothing. | |