Move shared qt/bitcoind initialization steps to shared functions.
AbandonedPublic
Actions

Authored by schancel on Nov 25 2018, 23:24.

Details

Reviewers

Group Reviewers

Restricted Project

Summary

Move shared initialization steps to their own functions. We eventually would like as
shared an initialization as possible so we can ensure that we can de-globalize
items such as the mempool.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

move-shared-init (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4119
Build 6309: Bitcoin ABC Buildbot (legacy)
Build 6308: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 25 2018, 23:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2018, 23:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel added a child revision: D2134: Nits in src/qt/init.cpp.Nov 25 2018, 23:32

Fabien added a subscriber: Fabien.Nov 26 2018, 11:53

Fabien added inline comments.

src/bitcoind.cpp
178	I don't know what the reason is for this comment, but the changes break this assumption. Did you look at the impact of moving the data dir lock before deamonization ?

schancel marked an inline comment as done.Nov 26 2018, 18:32

schancel added inline comments.

src/bitcoind.cpp
178	I don't see how this matters at all. deamonization does a double fork, and will inherit the lock.

Fix locking behavior when daemonizing

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4128: Diff 6107.Nov 26 2018, 19:56

Fabien added inline comments.Nov 26 2018, 20:31

src/bitcoind.cpp
169 ↗	(On Diff #6107)	You may leave this block unchanged, I see no value it these changes. I you want to fix daemonization => daemonizing, please also refactor the other comments in order to have them consistent.
src/init.cpp
1763 ↗	(On Diff #6107)	This should also be removed ?