Page MenuHomePhabricator

Record when a block was fully received and checked
Needs ReviewPublic

Authored by schancel on Mon, Nov 26, 23:14.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

As per title. This potentially enables punishment for block withholding as per Jonathan Toomim's ideas.

Test Plan
make VERBOSE=1 check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-D2128
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4145
Build 6361: Bitcoin ABC Teamcity Staging
Build 6360: arc lint + arc unit

Event Timeline

schancel created this revision.Mon, Nov 26, 23:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 26, 23:14
schancel updated this revision to Diff 6119.Mon, Nov 26, 23:16
schancel edited the summary of this revision. (Show Details)

Add missing sections

deadalnix requested changes to this revision.Mon, Nov 26, 23:44
deadalnix added inline comments.
src/validation.cpp
3845 ↗(On Diff #6119)

This method is there to do all the bookeeping happening once a block is found. It belongs in there.

This revision now requires changes to proceed.Mon, Nov 26, 23:44
schancel marked an inline comment as done.Tue, Nov 27, 01:43
schancel added inline comments.
src/validation.cpp
3845 ↗(On Diff #6119)

@deadalnix Okay, thank you. Will fix.

schancel updated this revision to Diff 6132.Tue, Nov 27, 16:09

Update per feedback

deadalnix added inline comments.Wed, Nov 28, 17:51
src/chain.h
143

This clearly conflicts with the goals of D2131