Page MenuHomePhabricator
Differential D2139

Record when a block was fully received and checked
AbandonedPublic
Actions

Authored by schancel on Nov 26 2018, 23:14.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

As per title. This potentially enables punishment for block withholding as per Jonathan Toomim's ideas.

Test Plan
make VERBOSE=1 check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-D2128
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4136
Build 6343: Bitcoin ABC Buildbot (legacy)
Build 6342: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 26 2018, 23:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2018, 23:14
Herald added a reviewer: deadalnix. · View Herald Transcript
schancel edited the summary of this revision. (Show Details)Nov 26 2018, 23:16
schancel added a parent revision: D2138: Revert "Record when block was fully received".
schancel updated this revision to Diff 6119.Nov 26 2018, 23:16
schancel edited the summary of this revision. (Show Details)

Add missing sections

teamcity added a subscriber: teamcity.Nov 26 2018, 23:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 26 2018, 23:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 26 2018, 23:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4135: Diff 6118.Nov 26 2018, 23:25
teamcity added a comment.Nov 26 2018, 23:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4136: Diff 6119.Nov 26 2018, 23:27
deadalnix requested changes to this revision.Nov 26 2018, 23:44
deadalnix added inline comments.
src/validation.cpp
3845

This method is there to do all the bookeeping happening once a block is found. It belongs in there.

This revision now requires changes to proceed.Nov 26 2018, 23:44
schancel marked an inline comment as done.Nov 27 2018, 01:43
schancel added inline comments.
src/validation.cpp
3845

@deadalnix Okay, thank you. Will fix.

schancel updated this revision to Diff 6132.Nov 27 2018, 16:09

Update per feedback

teamcity added a comment.Nov 27 2018, 16:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4145: Diff 6132.Nov 27 2018, 16:19
teamcity added a comment.Nov 27 2018, 16:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added inline comments.Nov 28 2018, 17:51
src/chain.h
143 ↗(On Diff #6132)

This clearly conflicts with the goals of D2131

schancel abandoned this revision.Mar 9 2019, 07:01

Revision Contents
Changeset List

PathSize
src/
18 lines
test/
25 lines
6 lines

Diff 6119

View Options

src/chain.h

Loading...
View Options

src/test/blockindex_tests.cpp

Loading...
View Options

src/validation.cpp

Loading...