Page MenuHomePhabricator

Enforce protocol message size against INV message size
ClosedPublic

Authored by jasonbcox on Nov 27 2018, 00:55.

Details

Summary

Need to enforce this check at compile time.

Test Plan

ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Nov 27 2018, 00:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2018, 00:55
jasonbcox changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Nov 27 2018, 00:56
deadalnix requested changes to this revision.Nov 27 2018, 00:59
deadalnix added inline comments.
src/net.h
55 ↗(On Diff #6122)

sizeof instead of 32 ?

This revision now requires changes to proceed.Nov 27 2018, 00:59
jasonbcox updated this revision to Diff 6123.Nov 27 2018, 01:23

Use sizeof instead of magic value

deadalnix accepted this revision.Nov 27 2018, 12:48
This revision is now accepted and ready to land.Nov 27 2018, 12:48
deadalnix changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Nov 27 2018, 12:49
This revision was automatically updated to reflect the committed changes.