Enforce protocol message size against INV message size
ClosedPublic
Actions

Authored by jasonbcox on Nov 27 2018, 00:55.

Details

Reviewers

deadalnix
schancel

Group Reviewers

Restricted Project

Commits

rSTAGINGeec5e1a47f3b: Enforce protocol message size against INV message size
rABCeec5e1a47f3b: Enforce protocol message size against INV message size

Summary

Need to enforce this check at compile time.

Test Plan

ninja

Diff Detail

Repository

rABC Bitcoin ABC

Branch

inv-push-after-release

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4139
Build 6349: Bitcoin ABC Buildbot (legacy)
Build 6348: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Nov 27 2018, 00:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2018, 00:55

jasonbcox changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Nov 27 2018, 00:56

deadalnix requested changes to this revision.Nov 27 2018, 00:59

deadalnix added inline comments.

src/net.h
55 ↗	(On Diff #6122)	sizeof instead of 32 ?

This revision now requires changes to proceed.Nov 27 2018, 00:59

Use sizeof instead of magic value

deadalnix accepted this revision.Nov 27 2018, 12:48

This revision is now accepted and ready to land.Nov 27 2018, 12:48

deadalnix changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Nov 27 2018, 12:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4139: Diff 6123.Nov 27 2018, 17:59

Closed by commit rABCeec5e1a47f3b: Enforce protocol message size against INV message size (authored by jasonbcox). · Explain WhyNov 27 2018, 18:07

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

net.h

4 lines

Diff 6123

View Options

Enforce protocol message size against INV message sizeClosedPublicActions