Page MenuHomePhabricator

Enforce protocol message size against INV message size
ClosedPublic

Authored by jasonbcox on Nov 27 2018, 00:55.

Details

Summary

Need to enforce this check at compile time.

Test Plan

ninja

Diff Detail

Repository
rABC Bitcoin ABC
Branch
inv-push-after-release
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4139
Build 6349: Bitcoin ABC Buildbot (legacy)
Build 6348: arc lint + arc unit

Event Timeline

jasonbcox changed the visibility from "Public (No Login Required)" to "Restricted Project (Project)".Nov 27 2018, 00:56
deadalnix requested changes to this revision.Nov 27 2018, 00:59
deadalnix added inline comments.
src/net.h
55 ↗(On Diff #6122)

sizeof instead of 32 ?

This revision now requires changes to proceed.Nov 27 2018, 00:59

Use sizeof instead of magic value

This revision is now accepted and ready to land.Nov 27 2018, 12:48
deadalnix changed the visibility from "Restricted Project (Project)" to "Public (No Login Required)".Nov 27 2018, 12:49
This revision was automatically updated to reflect the committed changes.