Page MenuHomePhabricator
Differential D2166

Remove unused variables and/or function calls
ClosedPublic
Actions

Authored by jasonbcox on Nov 30 2018, 23:59.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGebd95f0c7ddd: Remove unused variables and/or function calls
rABCebd95f0c7ddd: Remove unused variables and/or function calls
Summary

Backport 4-of-6 was skipped because the file was deleted in bitcoin-abc

This diff covers backport 5-of-6 for Core PR10781
https://github.com/bitcoin/bitcoin/pull/10781/commits/2e6080bbf31d5cc2e38e8a7b436e8ce1857e589b
T473
Depends on D2151

Test Plan

test_runner.py
test_runner.py p2p-fullblocktest
test_runner.py bip68-sequence
test_runner.py fundrawtransaction

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10781-5
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4214
Build 6494: Bitcoin ABC Buildbot (legacy)
Build 6493: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Nov 30 2018, 23:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2018, 23:59
teamcity added a subscriber: teamcity.Dec 1 2018, 00:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox updated this revision to Diff 6220.Dec 1 2018, 00:03

Fixed merged conflict on a single whitespace

jasonbcox edited the summary of this revision. (Show Details)Dec 1 2018, 00:04
jasonbcox added a parent revision: D2151: Use sys.exit(...) instead of exit(...): exit(...) should not be used in programs.
teamcity added a comment.Dec 1 2018, 00:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B4214: Diff 6219!Dec 1 2018, 00:10
teamcity added a comment.Dec 1 2018, 00:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

teamcity added a comment.Dec 1 2018, 00:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4215: Diff 6220.Dec 1 2018, 00:13
schancel accepted this revision.Dec 3 2018, 18:48
This revision is now accepted and ready to land.Dec 3 2018, 18:48
jasonbcox removed a reviewer: schancel.Dec 5 2018, 00:27
This revision now requires review to proceed.Dec 5 2018, 00:27
deadalnix accepted this revision.Dec 6 2018, 01:42
This revision is now accepted and ready to land.Dec 6 2018, 01:42
Fabien accepted this revision.Dec 6 2018, 08:17
jasonbcox added a child revision: D2185: Use the variable name _ for unused return values.Dec 10 2018, 01:32
Closed by commit rABCebd95f0c7ddd: Remove unused variables and/or function calls (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by jasonbcox). · Explain WhyDec 10 2018, 02:31
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
2 lines
1 line
1 line
14 lines
6 lines
16 lines
2 lines
test_framework/
12 lines
41 lines
10 lines
12 lines
20 lines
249 lines
2 lines

Diff 6219

View Options

test/functional/bip68-sequence.py

Loading...
View Options

test/functional/fundrawtransaction.py

Loading...
View Options

test/functional/import-rescan.py

Loading...
View Options

test/functional/importmulti.py

Loading...
View Options

test/functional/importprunedfunds.py

Loading...
View Options

test/functional/p2p-fullblocktest.py

Loading...
View Options

test/functional/rawtransactions.py

Loading...
View Options

test/functional/test_framework/address.py

Loading...
View Options

test/functional/test_framework/bignum.py

Loading...
View Options

test/functional/test_framework/blockstore.py

Loading...
View Options

test/functional/test_framework/mininode.py

Loading...
View Options

test/functional/test_framework/netutil.py

Loading...
View Options

test/functional/test_framework/script.py

Loading...
View Options

test/functional/wallet.py

Loading...