Differential D2166

Remove unused variables and/or function calls
ClosedPublic
Actions

Authored by jasonbcox on Nov 30 2018, 23:59.

Tags

None

Subscribers

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGebd95f0c7ddd: Remove unused variables and/or function calls
rABCebd95f0c7ddd: Remove unused variables and/or function calls

Summary

Backport 4-of-6 was skipped because the file was deleted in bitcoin-abc

This diff covers backport 5-of-6 for Core PR10781
https://github.com/bitcoin/bitcoin/pull/10781/commits/2e6080bbf31d5cc2e38e8a7b436e8ce1857e589b
T473
Depends on D2151

Test Plan

test_runner.py
test_runner.py p2p-fullblocktest
test_runner.py bip68-sequence
test_runner.py fundrawtransaction

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Nov 30 2018, 23:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2018, 23:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fixed merged conflict on a single whitespace

jasonbcox edited the summary of this revision. (Show Details)Dec 1 2018, 00:04

jasonbcox added a parent revision: D2151: Use sys.exit(...) instead of exit(...): exit(...) should not be used in programs.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B4214: Diff 6219!Dec 1 2018, 00:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4215: Diff 6220.Dec 1 2018, 00:13

schancel accepted this revision.Dec 3 2018, 18:48

This revision is now accepted and ready to land.Dec 3 2018, 18:48

jasonbcox removed a reviewer: schancel.Dec 5 2018, 00:27

This revision now requires review to proceed.Dec 5 2018, 00:27

deadalnix accepted this revision.Dec 6 2018, 01:42

This revision is now accepted and ready to land.Dec 6 2018, 01:42

Fabien accepted this revision.Dec 6 2018, 08:17

jasonbcox added a child revision: D2185: Use the variable name _ for unused return values.Dec 10 2018, 01:32

Closed by commit rABCebd95f0c7ddd: Remove unused variables and/or function calls (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by jasonbcox). · Explain WhyDec 10 2018, 02:31

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			test/functional/bip68-sequence.py (2 lines)
M			test/functional/fundrawtransaction.py (1 line)
M			test/functional/import-rescan.py (1 line)
M			test/functional/importmulti.py (14 lines)
M			test/functional/importprunedfunds.py (6 lines)
M			test/functional/p2p-fullblocktest.py (16 lines)
M			test/functional/rawtransactions.py (2 lines)
M			test/functional/test_framework/address.py (12 lines)
M			test/functional/test_framework/bignum.py (41 lines)
M			test/functional/test_framework/blockstore.py (10 lines)
M			test/functional/test_framework/mininode.py (12 lines)
M			test/functional/test_framework/netutil.py (20 lines)
M			test/functional/test_framework/script.py (249 lines)
M			test/functional/wallet.py (2 lines)

Diff 6320

test/functional/bip68-sequence.py

Loading...

test/functional/fundrawtransaction.py

Loading...

test/functional/import-rescan.py

Loading...

test/functional/importmulti.py

Loading...

test/functional/importprunedfunds.py

Loading...

test/functional/p2p-fullblocktest.py

Loading...

test/functional/rawtransactions.py

Loading...

test/functional/test_framework/address.py

Loading...

test/functional/test_framework/bignum.py

Loading...

test/functional/test_framework/blockstore.py

Loading...

test/functional/test_framework/mininode.py

Loading...

test/functional/test_framework/netutil.py

Loading...

test/functional/test_framework/script.py

Loading...

test/functional/wallet.py

Loading...