Details

Reviewers

schancel
markblundeberg

Group Reviewers

Restricted Project

Commits

rABC98f245df1538: [policy] Delete block policy estimator.

Summary

This commit removes the block policy estimator. It's currently basically useless,
and the algorithm for determining minimum fee isn't correct either. We will replace this
estimator using something that examines the active mempool.

Depends on D2037
Complete T499

Test Plan

make VERBOSE=1 check && ./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Dec 3 2018, 06:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 3 2018, 06:28

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4241: Diff 6246.Dec 3 2018, 06:40

Remove writing/reading of fee stats.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B4242: Diff 6247!Dec 3 2018, 06:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Remove test_framework dependency on silly file

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Include change to docs

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

schancel added a child revision: D2173: [WIP] Use mempool for fee estimates, not blocks..Dec 3 2018, 07:01

Harbormaster completed remote builds in B4243: Diff 6249.Dec 3 2018, 07:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4244: Diff 6250.Dec 3 2018, 07:04

Clean up some unnecessary globals

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Remove last vestigates of block policy estimator

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4246: Diff 6252!Dec 3 2018, 07:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4247: Diff 6253.Dec 3 2018, 07:18

Remove an extraneous whitespace

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4249: Diff 6255.Dec 3 2018, 07:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Delete yet another vestige

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4252: Diff 6258.Dec 3 2018, 09:13

deadalnix commandeered this revision.Jan 18 2019, 23:34

deadalnix edited reviewers, added: schancel; removed: deadalnix.

Reconstruct the patchset

Rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4575: Diff 6739.Jan 19 2019, 01:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4573: Diff 6737.Jan 19 2019, 01:36

Great idea, code changes look good.

src/policy/fees.h
28 ↗	(On Diff #6739)	will it be possible to get rid of this too (and FEE_SPACING above) ?

This revision is now accepted and ready to land.Jan 26 2019, 05:57

rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4719: Diff 6958.Jan 28 2019, 11:58

Closed by commit rABC98f245df1538: [policy] Delete block policy estimator. (authored by deadalnix). · Explain WhyJan 28 2019, 16:50

This revision was automatically updated to reflect the committed changes.

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	6246	2ff64b5		Dec 3 2018, 06:28	★	★
Diff 2	6247	2ff64b5	Remove writing/reading of fee stats.	Dec 3 2018, 06:43	★	★
Diff 3	6249	2ff64b5	Remove test_framework dependency on silly file	Dec 3 2018, 06:52	★	★
Diff 4	6250	2ff64b5	Include change to docs	Dec 3 2018, 06:54	★	★
Diff 5	6252	2ff64b5	Clean up some unnecessary globals	Dec 3 2018, 07:05	★	★
Diff 6	6253	2ff64b5	Remove last vestigates of block policy estimator	Dec 3 2018, 07:08	★	★
Diff 7	6255	2ff64b5	Remove an extraneous whitespace	Dec 3 2018, 07:22	★	★
Diff 8	6258	2ff64b5	Delete yet another vestige	Dec 3 2018, 09:03	★	★
Diff 9	6737	8e11bbd	Reconstruct the patchset	Jan 18 2019, 23:37	★	★
Diff 10	6739	53a858a	Rebase	Jan 19 2019, 00:51	★	★
Diff 11	6958	20b3125	rebase	Jan 28 2019, 11:42	★	★
Diff 12	6964	20b3125	rABC98f245df1538e3c1037e007ec369ed55fe94cdb4	Jan 28 2019, 16:50	★	★

Status	Author	Revision
Needs Revision	schancel	D2173 [WIP] Use mempool for fee estimates, not blocks.
Closed	deadalnix	D2172 [policy] Delete block policy estimator.
Closed	Fabien	D2037 Update mempool fee estimator to factor in rollingMinimumFeerate

D3934 Merge #11338: qt: Backup former GUI settings on `-resetguisettings`

·Reviewers: deadalnix, Fabien, jasonbcox, Restricted Owners Package, Restricted Project

Wed, Aug 21, 23:13

Author: nakihito

D3897 Merge #12709: [wallet] shuffle sendmany recipients ordering

·Reviewers: deadalnix, Fabien, jasonbcox, Restricted Owners Package, Restricted Project

Fri, Aug 16, 23:51

Author: nakihito

D3805 Merge #12716: Fix typos and cleanup in various files

·Reviewers: deadalnix, Fabien, jasonbcox, Restricted Owners Package, Restricted Project

Thu, Aug 8, 19:44

Author: nakihito

			Path	Packages
M			doc/files.md (1 line)
M			doc/release-notes.md (4 lines)
M			src/init.cpp (25 lines)
M			src/policy/fees.h (247 lines)
M			src/policy/fees.cpp (531 lines)
M			src/test/policyestimator_tests.cpp (233 lines)
M			src/txmempool.h (7 lines)
M			src/txmempool.cpp (60 lines)
M			src/wallet/fees.h (1 line)
M			test/functional/test_framework/test_framework.py (2 lines)

[policy] Delete block policy estimator.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 6964

doc/files.md

doc/release-notes.md

src/init.cpp

src/policy/fees.h

src/policy/fees.cpp

src/test/policyestimator_tests.cpp

src/txmempool.h

src/txmempool.cpp

src/wallet/fees.h

test/functional/test_framework/test_framework.py

[policy] Delete block policy estimator.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6964

doc/files.md

doc/release-notes.md

src/init.cpp

src/policy/fees.h

src/policy/fees.cpp

src/test/policyestimator_tests.cpp

src/txmempool.h

src/txmempool.cpp

src/wallet/fees.h

test/functional/test_framework/test_framework.py

[policy] Delete block policy estimator.
ClosedPublic
Actions

Revision Contents
Changeset List