Page MenuHomePhabricator

[policy] Delete block policy estimator.
ClosedPublic

Authored by deadalnix on Dec 3 2018, 06:28.

Details

Reviewers
schancel
markblundeberg
Group Reviewers
Restricted Project
Commits
rABC98f245df1538: [policy] Delete block policy estimator.
Summary

This commit removes the block policy estimator. It's currently basically useless,
and the algorithm for determining minimum fee isn't correct either. We will replace this
estimator using something that examines the active mempool.

Depends on D2037
Complete T499

Test Plan
make VERBOSE=1 check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Dec 3 2018, 06:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 3 2018, 06:28
schancel updated this revision to Diff 6247.Dec 3 2018, 06:43

Remove writing/reading of fee stats.

schancel updated this revision to Diff 6249.Dec 3 2018, 06:52

Remove test_framework dependency on silly file

schancel updated this revision to Diff 6250.Dec 3 2018, 06:54

Include change to docs

schancel updated this revision to Diff 6252.Dec 3 2018, 07:05

Clean up some unnecessary globals

schancel updated this revision to Diff 6253.Dec 3 2018, 07:08

Remove last vestigates of block policy estimator

schancel updated this revision to Diff 6255.Dec 3 2018, 07:22

Remove an extraneous whitespace

schancel updated this revision to Diff 6258.Dec 3 2018, 09:03

Delete yet another vestige

deadalnix commandeered this revision.Jan 18 2019, 23:34
deadalnix edited reviewers, added: schancel; removed: deadalnix.
deadalnix updated this revision to Diff 6737.Jan 18 2019, 23:38

Reconstruct the patchset

markblundeberg added a subscriber: markblundeberg.

Great idea, code changes look good.

src/policy/fees.h
28 ↗(On Diff #6739)

will it be possible to get rid of this too (and FEE_SPACING above) ?

This revision is now accepted and ready to land.Sat, Jan 26, 05:57
This revision was automatically updated to reflect the committed changes.