Details

Reviewers

Group Reviewers

Restricted Project

Summary

This commit removes the block policy estimator. It's currently basically useless,
and the algorithm for determining minimum fee isn't correct either. We will replace this
estimator using something that examines the active mempool.

Depends on D2037
Complete T499

Test Plan

make VERBOSE=1 check && ./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

delete-fee-estimator (branched from master)

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 4252
Build 6569: Bitcoin ABC Teamcity Staging
Build 6568: arc lint + arc unit

Event Timeline

schancel created this revision.Mon, Dec 3, 06:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Dec 3, 06:28

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4241: Diff 6246.Mon, Dec 3, 06:40

Remove writing/reading of fee stats.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B4242: Diff 6247!Mon, Dec 3, 06:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Remove test_framework dependency on silly file

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Include change to docs

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

schancel added a child revision: D2173: [WIP] Use mempool for fee estimates, not blocks..Mon, Dec 3, 07:01

Harbormaster completed remote builds in B4243: Diff 6249.Mon, Dec 3, 07:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4244: Diff 6250.Mon, Dec 3, 07:04

Clean up some unnecessary globals

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Remove last vestigates of block policy estimator

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4246: Diff 6252!Mon, Dec 3, 07:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4247: Diff 6253.Mon, Dec 3, 07:18

Remove an extraneous whitespace

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4249: Diff 6255.Mon, Dec 3, 07:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Delete yet another vestige

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4252: Diff 6258.Mon, Dec 3, 09:13

			Path	Packages
M			doc/files.md (1 line)
M			doc/release-notes.md (2 lines)
M			src/init.cpp (25 lines)
M			src/policy/fees.h (248 lines)
M			src/policy/fees.cpp (531 lines)
M			src/test/policyestimator_tests.cpp (236 lines)
M			src/txmempool.h (7 lines)
M			src/txmempool.cpp (60 lines)
M			src/wallet/fees.h (1 line)
M			test/functional/test_framework/test_framework.py (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	6246	2ff64b5		Mon, Dec 3, 06:28	★	★
Diff 2	6247	2ff64b5	Remove writing/reading of fee stats.	Mon, Dec 3, 06:43	★	★
Diff 3	6249	2ff64b5	Remove test_framework dependency on silly file	Mon, Dec 3, 06:52	★	★
Diff 4	6250	2ff64b5	Include change to docs	Mon, Dec 3, 06:54	★	★
Diff 5	6252	2ff64b5	Clean up some unnecessary globals	Mon, Dec 3, 07:05	★	★
Diff 6	6253	2ff64b5	Remove last vestigates of block policy estimator	Mon, Dec 3, 07:08	★	★
Diff 7	6255	2ff64b5	Remove an extraneous whitespace	Mon, Dec 3, 07:22	★	★
Diff 8	6258	2ff64b5	Delete yet another vestige	Mon, Dec 3, 09:03	★	★

Status	Author	Revision
Needs Review	schancel	D2173 [WIP] Use mempool for fee estimates, not blocks.
Needs Review	schancel	D2172 [policy] Delete block policy estimator.
Needs Review	schancel	D2037 Update mempool fee estimator to factor in rollingMinimumFeerate

[policy] Delete block policy estimator.
Needs ReviewPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 6258

doc/files.md

doc/release-notes.md

src/init.cpp

src/policy/fees.h

src/policy/fees.cpp

src/test/policyestimator_tests.cpp

src/txmempool.h

src/txmempool.cpp

src/wallet/fees.h

test/functional/test_framework/test_framework.py

[policy] Delete block policy estimator.Needs ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6258

doc/files.md

doc/release-notes.md

src/init.cpp

src/policy/fees.h

src/policy/fees.cpp

src/test/policyestimator_tests.cpp

src/txmempool.h

src/txmempool.cpp

src/wallet/fees.h

test/functional/test_framework/test_framework.py

[policy] Delete block policy estimator.
Needs ReviewPublic
Actions

Revision Contents
Changeset List