Page MenuHomePhabricator

[WIP] Use mempool for fee estimates, not blocks.
Needs RevisionPublic

Authored by schancel on Dec 3 2018, 07:01.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Summary

Implement a class that returns the median of the feerates in the mempool
currently. Complexity should be O(nlogn) for inserts and constant time for
obtaining the median.

Depends on D2172

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fee-estimation (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4251
Build 6567: Bitcoin ABC Buildbot (legacy)
Build 6566: arc lint + arc unit

Event Timeline

schancel marked an inline comment as done.
This comment was removed by schancel.
schancel added inline comments.
src/policy/fees.cpp
68 ↗(On Diff #6256)

Tests fail without this. However, I can't find any mistake above with respect to the comparator and heap operations.

24 ↗(On Diff #6254)

Just looking for a concept ACK. Right now I've got something mixed up in the running median logic.

jasonbcox requested changes to this revision.Jan 2 2019, 18:41
jasonbcox added a subscriber: jasonbcox.

Need to cleanup the review queue, so setting request changes for now.

This revision now requires changes to proceed.Jan 2 2019, 18:41