Page MenuHomePhabricator
Differential D2183

Add backporting suggestion to CONTRIBUTING.md
ClosedPublic
Actions

Authored by Mengerian on Dec 9 2018, 05:07.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING70b73611affe: Add backporting suggestion to CONTRIBUTING.md
rABC70b73611affe: Add backporting suggestion to CONTRIBUTING.md
Summary

Point to the backporting.md document if people are looking
for something to work on.

Test Plan

Read it

Diff Detail

Repository
rABC Bitcoin ABC
Branch
backporting
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4300
Build 6665: Bitcoin ABC Buildbot (legacy)
Build 6664: arc lint + arc unit

Event Timeline

Mengerian created this revision.Dec 9 2018, 05:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 9 2018, 05:07
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Dec 9 2018, 05:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 9 2018, 05:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4287: Diff 6308.Dec 9 2018, 05:19
jasonbcox added inline comments.Dec 10 2018, 01:05
CONTRIBUTING.md
189 ↗(On Diff #6308)

I think it needs to include the impact or some level of direction, otherwise no one will want to work on this. Maybe word it something like:
You can also [backport](doc/backporting.md) changes from Bitcoin Core. Especially be on the lookout for bug fixes, code cleanup, and important refactors, as these help improve Bitcoin ABC despite consensus-level differences between Bitcoin Cash and Bitcoin Core.

jasonbcox requested changes to this revision.Dec 10 2018, 01:07
jasonbcox added inline comments.
CONTRIBUTING.md
189 ↗(On Diff #6308)

Alternatively, if this is too wordy for CONTRIBUTING (it probably is), then maybe move the impact/direction to backporting.md. I noticed the intro in that doc is practically non-existent.

This revision now requires changes to proceed.Dec 10 2018, 01:07
Mengerian updated this revision to Diff 6324.Dec 10 2018, 17:12

Incorporate Jason's suggestion for more direction in the backporting
document.

teamcity added a comment.Dec 10 2018, 17:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 10 2018, 17:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4300: Diff 6324.Dec 10 2018, 17:23
deadalnix accepted this revision.Dec 11 2018, 01:06
jasonbcox accepted this revision.Dec 11 2018, 04:24
This revision is now accepted and ready to land.Dec 11 2018, 04:24
Mengerian updated this revision to Diff 6326.Dec 11 2018, 05:49

rebase

Closed by commit rABC70b73611affe: Add backporting suggestion to CONTRIBUTING.md (authored by Mengerian). · Explain WhyDec 11 2018, 05:50
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Dec 11 2018, 05:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 11 2018, 06:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4301: Diff 6326.Dec 11 2018, 06:00

Revision Contents
Changeset List

PathSize
1 line
doc/
9 lines

Diff 6324

View Options

CONTRIBUTING.md

Loading...
View Options

doc/backporting.md

Loading...