Page MenuHomePhabricator

Add backporting suggestion to CONTRIBUTING.md
ClosedPublic

Authored by Mengerian on Dec 9 2018, 05:07.

Details

Summary

Point to the backporting.md document if people are looking
for something to work on.

Test Plan

Read it

Diff Detail

Repository
rABC Bitcoin ABC
Branch
backporting
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4300
Build 6665: Bitcoin ABC Buildbot (legacy)
Build 6664: arc lint + arc unit

Event Timeline

CONTRIBUTING.md
189 ↗(On Diff #6308)

I think it needs to include the impact or some level of direction, otherwise no one will want to work on this. Maybe word it something like:
You can also [backport](doc/backporting.md) changes from Bitcoin Core. Especially be on the lookout for bug fixes, code cleanup, and important refactors, as these help improve Bitcoin ABC despite consensus-level differences between Bitcoin Cash and Bitcoin Core.

jasonbcox requested changes to this revision.Dec 10 2018, 01:07
jasonbcox added inline comments.
CONTRIBUTING.md
189 ↗(On Diff #6308)

Alternatively, if this is too wordy for CONTRIBUTING (it probably is), then maybe move the impact/direction to backporting.md. I noticed the intro in that doc is practically non-existent.

This revision now requires changes to proceed.Dec 10 2018, 01:07

Incorporate Jason's suggestion for more direction in the backporting
document.

This revision is now accepted and ready to land.Dec 11 2018, 04:24
This revision was automatically updated to reflect the committed changes.