Page MenuHomePhabricator

Remove redundant connect_nodes call in

Authored by jasonbcox on Dec 13 2018, 01:47.



setup_network does this automatically, so this call is redundant.
Originally, I discovered this while looking for the root cause of this test's

Test Plan

for i in {1..150}; do ./ abc-parkedchain; done
Test is still flaky, but passes 99%+ of the time with this change still.

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

Fabien requested changes to this revision.Dec 13 2018, 16:06
Fabien added inline comments.
129 ↗(On Diff #6335)

This should not be needed. I suppose that you want the ensure that node tip and parking_node tip is the same, which is tested below.
This has been discussed with @deadalnix in another diff, and using a dedicated wait_until function seems to be a better way to do this:

def wait_for_tip(node, tip):
    def check_tip():
        return node.getbestblockhash() == tip
wait_for_tip(parking_node, good_tip)
This revision now requires changes to proceed.Dec 13 2018, 16:06

Use wait_until according to feedback

This revision is now accepted and ready to land.Dec 22 2018, 08:50
This revision was automatically updated to reflect the committed changes.